From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE458C77B73 for ; Mon, 5 Jun 2023 17:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232762AbjFERWx (ORCPT ); Mon, 5 Jun 2023 13:22:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbjFERWw (ORCPT ); Mon, 5 Jun 2023 13:22:52 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE6C91; Mon, 5 Jun 2023 10:22:49 -0700 (PDT) X-GND-Sasl: herve.codina@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685985768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Berwdtb2uXHQbSksaaVPK3mZrvObJ1lWrE4UzrcIf8M=; b=J7ev+niTsg1xzPdC/Z0LVxKv4Z42cGvd9zc2KeBD1xxv+tqyeHe/4J8ImQTFJ1AoRgwgFN 6ojrllCzR4ja6qcd8Etya0M3KkgPxP7cdNUzzM1mBqdz0+9jfeouUaa6+qH29biRkSjfrN DEIv/KSc/UuFrVmO58z9vm5utSERq6eCX49QApf1GYrUKVvHRTAtTYXX/eis3QNiXJMu6m unP5K6zs/HR9ux7R15lM8AbrvRMKbugnYtaMO8wRVXXYMabKWLmZaZTrLy4l+nDei2D3CH yOnw8Ft+VslMGLTB3zGn7OVLUIwcfgiqpz9hy1ufyO1B+48vf2k025F3lQLDcw== X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 30441240009; Mon, 5 Jun 2023 17:22:46 +0000 (UTC) Date: Mon, 5 Jun 2023 19:22:45 +0200 From: Herve Codina To: Jonathan Cameron Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices Message-ID: <20230605192245.4132e0ae@bootlin.com> In-Reply-To: <20230528183855.0c95d308@jic23-huawei> References: <20230523151223.109551-1-herve.codina@bootlin.com> <20230523151223.109551-8-herve.codina@bootlin.com> <20230528183855.0c95d308@jic23-huawei> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jonathan, On Sun, 28 May 2023 18:38:55 +0100 Jonathan Cameron wrote: > On Tue, 23 May 2023 17:12:21 +0200 > Herve Codina wrote: > > > Industrial I/O devices can be present in the audio path. > > These devices needs to be used as audio components in order to be fully > > integrated in the audio path. > > > > This support allows to consider these Industrial I/O devices as auxliary > > audio devices and allows to control them using mixer controls. > > > > Signed-off-by: Herve Codina > > --- > > > diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c > > new file mode 100644 > > index 000000000000..21575c4b35fd > > --- /dev/null > > +++ b/sound/soc/codecs/audio-iio-aux.c > > @@ -0,0 +1,302 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +// > > +// audio-iio-aux.c -- ALSA SoC glue to use IIO devices as audio components > > +// > > +// Copyright 2023 CS GROUP France > > +// > > +// Author: Herve Codina > > + > > +#include > > +#include > > #include ideally to pick up > the of_device_id definition without bouncing through some non > obvious header path. Right, will be replaced by in the next iteration. Thanks for the review, Hervé > > > > +#include > > +#include > > +#include > > Otherwise, the IIO elements of this look good. So for those at least > Reviewed-by: Jonathan Cameron > > I don't have enough knowledge of the snd stuff to review those > parts. > > Jonathan > >