Re: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.

What does "allowed anyway" mean?
And following from that, why not modify the min/maxItems to suit
reality, rather than remove them. Is there enforcement from elsewhere?

> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

I suspect that meant that the property was in the dt but not in the
binding at the time of the conversion.

Cheers,
Conor.

> 
> Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> properties.
> 
>  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> index 786cfd71cb7eb..3c28ec50f0979 100644
> --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> @@ -32,15 +32,6 @@ properties:
>    clock-names:
>      const: phy_ref
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-parents:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    "#phy-cells":
>      const: 0
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]