From: Yunfei Dong <yunfei.dong@mediatek.com>
To: "Chen-Yu Tsai" <wenst@chromium.org>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2,01/10] media: mediatek: vcodec: remove unused parameter
Date: Wed, 7 Jun 2023 16:48:52 +0800 [thread overview]
Message-ID: <20230607084901.28021-2-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20230607084901.28021-1-yunfei.dong@mediatek.com>
remove unused parameter in struct mtk_vcodec_dev.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 --
drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h | 6 ------
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
index d41f2121b94f..03721eda2769 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
@@ -336,8 +336,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
goto err_core_workq;
}
- init_waitqueue_head(&dev->queue);
-
vfd_dec = video_device_alloc();
if (!vfd_dec) {
mtk_v4l2_err("Failed to allocate video device");
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
index f17d67e781c9..e3230a4d7b8e 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
@@ -448,10 +448,7 @@ struct mtk_vcodec_enc_pdata {
* @decode_workqueue: decode work queue
* @encode_workqueue: encode work queue
*
- * @int_cond: used to identify interrupt condition happen
- * @int_type: used to identify what kind of interrupt condition happen
* @dev_mutex: video_device lock
- * @queue: waitqueue for waiting for completion of device commands
*
* @dec_irq: decoder irq resource
* @enc_irq: h264 encoder irq resource
@@ -496,10 +493,7 @@ struct mtk_vcodec_dev {
struct workqueue_struct *decode_workqueue;
struct workqueue_struct *encode_workqueue;
- int int_cond;
- int int_type;
struct mutex dev_mutex;
- wait_queue_head_t queue;
int dec_irq;
int enc_irq;
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
index 5df0a22ff3b5..a56652e476c2 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
@@ -311,8 +311,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
goto err_res;
}
- init_waitqueue_head(&dev->queue);
-
/* allocate video device for encoder and register it */
vfd_enc = video_device_alloc();
if (!vfd_enc) {
--
2.18.0
next prev parent reply other threads:[~2023-06-07 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:48 [PATCH v2,0/10] media: mediatek: vcodec: separate encoder and decoder Yunfei Dong
2023-06-07 8:48 ` Yunfei Dong [this message]
2023-06-07 8:48 ` [PATCH v2,02/10] media: mediatek: vcodec: align fw interface Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,03/10] media: mediatek: vcodec: re-write shared interface Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,04/10] media: mediatek: vcodec: remove the dependency of debug log Yunfei Dong
2023-06-08 1:41 ` Nicolas Dufresne
2023-06-08 7:27 ` Yunfei Dong (董云飞)
2023-06-08 13:11 ` Nicolas Dufresne
2023-06-08 14:06 ` AngeloGioacchino Del Regno
2023-06-08 15:17 ` Nicolas Dufresne
2023-06-11 2:09 ` Yunfei Dong (董云飞)
2023-06-14 9:17 ` Yunfei Dong (董云飞)
2023-06-14 11:50 ` AngeloGioacchino Del Regno
2023-06-07 8:48 ` [PATCH v2,05/10] mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,06/10] mediatek: vcodec: separate struct mtk_vcodec_ctx Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,07/10] mediatek: vcodec: separate struct mtk_vcodec_dev Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,08/10] mediatek: vcodec: fix unreasonable parameter definition and style Yunfei Dong
2023-06-07 8:49 ` [PATCH v2,09/10] mediatek: vcodec: remove unused include header Yunfei Dong
2023-06-07 8:49 ` [PATCH v2,10/10] mediatek: vcodec: separete decoder and encoder Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607084901.28021-2-yunfei.dong@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=stevecho@chromium.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).