From: Yunfei Dong <yunfei.dong@mediatek.com>
To: "Chen-Yu Tsai" <wenst@chromium.org>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2,08/10] mediatek: vcodec: fix unreasonable parameter definition and style
Date: Wed, 7 Jun 2023 16:48:59 +0800 [thread overview]
Message-ID: <20230607084901.28021-9-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20230607084901.28021-1-yunfei.dong@mediatek.com>
Fix unreasonable coding style.
Fix unreasonable parameter definition.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
.../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h | 4 ++--
.../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
index a18ba8f32d41..1a0375dd5b6d 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
@@ -19,7 +19,7 @@
#define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)
/*
- * struct mtk_vdec_format_types - Structure used to get supported
+ * enum mtk_vdec_format_types - Structure used to get supported
* format types according to decoder capability
*/
enum mtk_vdec_format_types {
@@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev {
const struct mtk_vcodec_dec_pdata *vdec_pdata;
struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;
/* decoder hardware mutex lock */
struct mutex dec_mutex[MTK_VDEC_HW_MAX];
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
index a88ef9078848..4804d8531a4e 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
@@ -32,13 +32,13 @@
*/
struct mtk_vcodec_enc_pdata {
bool uses_ext;
- unsigned long min_bitrate;
- unsigned long max_bitrate;
+ u64 min_bitrate;
+ u64 max_bitrate;
const struct mtk_video_fmt *capture_formats;
size_t num_capture_formats;
const struct mtk_video_fmt *output_formats;
size_t num_output_formats;
- int core_id;
+ u8 core_id;
bool uses_34bit;
};
@@ -208,7 +208,7 @@ struct mtk_vcodec_enc_dev {
const struct mtk_vcodec_enc_pdata *venc_pdata;
struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;
/* encoder hardware mutex lock */
struct mutex enc_mutex;
--
2.18.0
next prev parent reply other threads:[~2023-06-07 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:48 [PATCH v2,0/10] media: mediatek: vcodec: separate encoder and decoder Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,01/10] media: mediatek: vcodec: remove unused parameter Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,02/10] media: mediatek: vcodec: align fw interface Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,03/10] media: mediatek: vcodec: re-write shared interface Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,04/10] media: mediatek: vcodec: remove the dependency of debug log Yunfei Dong
2023-06-08 1:41 ` Nicolas Dufresne
2023-06-08 7:27 ` Yunfei Dong (董云飞)
2023-06-08 13:11 ` Nicolas Dufresne
2023-06-08 14:06 ` AngeloGioacchino Del Regno
2023-06-08 15:17 ` Nicolas Dufresne
2023-06-11 2:09 ` Yunfei Dong (董云飞)
2023-06-14 9:17 ` Yunfei Dong (董云飞)
2023-06-14 11:50 ` AngeloGioacchino Del Regno
2023-06-07 8:48 ` [PATCH v2,05/10] mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,06/10] mediatek: vcodec: separate struct mtk_vcodec_ctx Yunfei Dong
2023-06-07 8:48 ` [PATCH v2,07/10] mediatek: vcodec: separate struct mtk_vcodec_dev Yunfei Dong
2023-06-07 8:48 ` Yunfei Dong [this message]
2023-06-07 8:49 ` [PATCH v2,09/10] mediatek: vcodec: remove unused include header Yunfei Dong
2023-06-07 8:49 ` [PATCH v2,10/10] mediatek: vcodec: separete decoder and encoder Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607084901.28021-9-yunfei.dong@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=stevecho@chromium.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).