Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Arseniy,

AVKrasnov@sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:

> Add description of 'nand-rb' property. Use "Fixes" because this property
> must be supported since the beginning. For this controller 'nand-rb' is
> stored in the controller node (not in chip), because it has only single
> r/b wire for all chips.

Sorry if I mislead you in the first place, but you could definitely
have two chips and only one with RB wired. It needs to be defined in
the chips.

Please keep the bindings and driver changes related to this in the same
series.

> 
> Fixes: fbc00b5e746f ("dt-bindings: nand: meson: convert txt to yaml")
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
>  Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> index 28fb9a7dd70f..866edf800b81 100644
> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> @@ -37,6 +37,8 @@ properties:
>        - const: core
>        - const: device
>  
> +  nand-rb: true
> +
>  patternProperties:
>    "^nand@[0-7]$":
>      type: object
> @@ -81,6 +83,7 @@ examples:
>  
>        pinctrl-0 = <&nand_pins>;
>        pinctrl-names = "default";
> +      nand-rb = "true";
>  
>        #address-cells = <1>;
>        #size-cells = <0>;


Thanks,
Miquèl