From: Jakub Kicinski <kuba@kernel.org>
To: Raymond Hackley <raymondhackley@protonmail.com>
Cc: linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jeremy Kerr" <jk@codeconstruct.com.au>,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply
Date: Wed, 7 Jun 2023 21:36:20 -0700 [thread overview]
Message-ID: <20230607213620.4087b0e2@kernel.org> (raw)
In-Reply-To: <20230606072454.145106-1-raymondhackley@protonmail.com>
On Tue, 06 Jun 2023 07:25:55 +0000 Raymond Hackley wrote:
> + if (r != -EPROBE_DEFER)
> + dev_err(dev,
> + "Failed to get regulator pvdd: %d\n",
> + r);
> + return r;
dev_err_probe() ?
> + r = devm_add_action_or_reset(dev, nxp_nci_i2c_poweroff, phy);
> + if (r < 0) {
> + nfc_err(dev, "Failed to install poweroff handler: %d\n",
> + r);
> + nxp_nci_i2c_poweroff(phy);
The _or_reset() stands for "we'll call the action for you if we can't
add it". Don't call poweroff again.
--
pw-bot: cr
prev parent reply other threads:[~2023-06-08 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:24 [PATCH 0/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply Raymond Hackley
2023-06-06 7:25 ` [PATCH 1/2] dt-bindings: nfc: nxp-nci: document pvdd-supply Raymond Hackley
2023-06-06 8:29 ` Krzysztof Kozlowski
2023-06-06 7:25 ` [PATCH 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply Raymond Hackley
2023-06-08 4:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607213620.4087b0e2@kernel.org \
--to=kuba@kernel.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).