From: Conor Dooley <conor.dooley@microchip.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Conor Dooley <conor@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Liu Ying <victor.liu@nxp.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
Date: Thu, 8 Jun 2023 08:59:10 +0100 [thread overview]
Message-ID: <20230608-oven-coerce-e0c3f16d58a9@wendy> (raw)
In-Reply-To: <1855461.tdWV9SEqCh@steina-w>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> Hi Conor,
>
> Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > * PGP Signed by an unknown key
> >
> > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > > more than just one clock using these properties.
> >
> > What does "allowed anyway" mean?
> > And following from that, why not modify the min/maxItems to suit
> > reality, rather than remove them. Is there enforcement from elsewhere?
>
> As Liu pointed out, assigned-clock* were considered a generic property added
> by default at that time. With that support added there is no need to specify
> these properties in this bindings again.
> Despite that you never know in advance how many items you will have to add to
> assigned-clock* properties, that's totally different to 'clocks', it may even
> depend on board specific clock setups.
Sounds grand to me. I think it'd be good in the future to explain
*where* the enforcement comes from, rather than saying something like
"allowed anyway". Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-08 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:44 [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties Alexander Stein
2023-06-06 18:21 ` Conor Dooley
2023-06-08 7:31 ` [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: " Alexander Stein
2023-06-08 7:59 ` Conor Dooley [this message]
2023-06-08 8:07 ` Alexander Stein
2023-06-07 2:45 ` [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: " Ying Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608-oven-coerce-e0c3f16d58a9@wendy \
--to=conor.dooley@microchip.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=victor.liu@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox