From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A89C7EE37 for ; Thu, 8 Jun 2023 06:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234332AbjFHGgo (ORCPT ); Thu, 8 Jun 2023 02:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234369AbjFHGgn (ORCPT ); Thu, 8 Jun 2023 02:36:43 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 745DC270D; Wed, 7 Jun 2023 23:36:42 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D586E80E0; Thu, 8 Jun 2023 06:36:40 +0000 (UTC) Date: Thu, 8 Jun 2023 09:36:39 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Nishanth Menon , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml Message-ID: <20230608063639.GD14287@atomide.com> References: <20230605095216.18864-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Krzysztof Kozlowski [230607 18:17]: > On 05/06/2023 11:52, Tony Lindgren wrote: > > +title: Pinctrl driver for hardware with a single register for one or more pins > > I asked to drop the driver references but it is still here. Bindings are > not describing drivers. > > "Generic Pin Controller with a Single Register for One or More Pins" Oh right it's supposed to describe hardware, will update thanks. > > +patternProperties: > > + '-pins$|-pin': > > you did not implement my comments fully, probably we misunderstood each > other. Why do you allow anything after '-pin'? Let's make it pure suffix > for both cases: '-pins?$' I'll check what kind of node renaming that would cause. At least TI arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your preference to rename all those nodes to -default-pins and -wakeup-pins? Regards, Tony