devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml
Date: Thu, 8 Jun 2023 11:55:34 +0300	[thread overview]
Message-ID: <20230608085534.GE14287@atomide.com> (raw)
In-Reply-To: <19710587-533c-f6df-9842-06a8e2db263c@linaro.org>

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230608 06:57]:
> On 08/06/2023 08:36, Tony Lindgren wrote:
> > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230607 18:17]:
> >> On 05/06/2023 11:52, Tony Lindgren wrote:
> >>> +patternProperties:
> >>> +  '-pins$|-pin':
> >>
> >> you did not implement my comments fully, probably we misunderstood each
> >> other. Why do you allow anything after '-pin'? Let's make it pure suffix
> >> for both cases: '-pins?$'
> > 
> > I'll check what kind of node renaming that would cause. At least TI
> > arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your
> > preference to rename all those nodes to -default-pins and -wakeup-pins?
> 
> No, pattern matching TI SoC is fine, but your current also doesn't. Or
> rather - matches by mistake. You do not allow anything after -pins.

So after the earlier dts node name clean-up, looks like it's only few hundred
TI pins to rename. Not sure I want to add SoC specific handling for TI. Folks
will try to use -pins-default, -pins-sleep, -pins-idle etc..

How about let's just fix the remaining dts files and then we can only
allow -pin or -pins suffix? The match would be just '-pins$|-pin$ with a
preference for -pins as it's a group that might get more pins added to it
later on.

Regards,

Tony

      reply	other threads:[~2023-06-08  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05  9:52 [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml Tony Lindgren
2023-06-07 18:17 ` Krzysztof Kozlowski
2023-06-08  6:36   ` Tony Lindgren
2023-06-08  6:57     ` Krzysztof Kozlowski
2023-06-08  8:55       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608085534.GE14287@atomide.com \
    --to=tony@atomide.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).