RE: [PATCH v6 05/11] dt-bindings: rtc: isl1208: Convert to json-schema

Biju Das
2023-06-09T08:02:02Z

Hi Trent Piepho,

Thanks for the feedback.

> Subject: Re: [PATCH v6 05/11] dt-bindings: rtc: isl1208: Convert to json-
> schema
>
> On Fri, Jun 2, 2023 at 7:24 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Convert the isl1208 RTC device tree binding documentation to json-
> schema.
> >
> > Update the example to match reality.
>
> I still don't know why you say this and changed the example to be as
> simple as possible.
>
> Did you test it and does it not work with the actual driver? I looked at
> the code for parsing OF interrupts and it does not look like anything has
> changed to make it not work. Nor do I see anything incorrect in the
> original example. Can you explain what you think is wrong with the
> original example?

There is nothing wrong with example. The only reason is there is no dts in mainline
matching with example.

If I am correct, example should match with reality. If it is not the case, I am happy to
update the example.

I have seen people(including me) sending patches to update example with reality.

Note:
Can you please confirm rtctest[1] is passing with interrupts in your environment?

In my board interrupt is not populated. So it is good to know RTC test which involves
IRQ is passing in your environment.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/tools/testing/selftests/rtc/rtctest.c?h=next-20230609

Cheers,
Biju

>
> > +
> > + rtc_twi: rtc@6f {
> > + compatible = "isil,isl1208";
> > + reg = <0x6f>;
> > + };
> > + };
> > --
> > 2.25.1
> >