[PATCH 0/3] imx8mq DT fixes

[PATCH 0/3] imx8mq DT fixes

[Alexander Stein]

Hi,

this series fixes various dtbs_check warnings for imx8mq.
Admittedly I do not know why lcdif is currently usable without apb and axi
clocks configured.

Best regards,
Alexander

Alexander Stein (3):
  arm64: dts: imx8mq: Fix lcdif compatible
  arm64: dts: imx8mq: Fix lcdif clocks
  arm64: dts: imx8mq: Add missing pci property

 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH 1/3] arm64: dts: imx8mq: Fix lcdif compatible

[Alexander Stein]

"fsl,imx8mq-lcdif" is compatible to "fsl,imx6sx-lcdif", adjust the list
accordingly. Fixes the dtbs_check warning:
imx8mq-tqma8mq-mba8mx.dtb: lcd-controller@30320000: compatible: 'oneOf'
conditional failed, one must be fixed:
 ['fsl,imx8mq-lcdif', 'fsl,imx28-lcdif'] is too long
 'fsl,imx8mq-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif',
 'fsl,imx6sx-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif']
 'fsl,imx6sx-lcdif' was expected

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 54e374e81ce6c..b7f296fe5bb8c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -547,7 +547,7 @@ sdma2: dma-controller@302c0000 {
 			};
 
 			lcdif: lcd-controller@30320000 {
-				compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";
+				compatible = "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif";
 				reg = <0x30320000 0x10000>;
 				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
-- 
2.34.1

[PATCH 2/3] arm64: dts: imx8mq: Fix lcdif clocks

[Alexander Stein]

Add display APB and AXI clocks as required by bindings. This fixes the
warnings:
lcd-controller@30320000: clocks: [[2, 128]] is too short
        From schema: Documentation/devicetree/bindings/display/fsl,lcdif.yaml
lcd-controller@30320000: clock-names: ['pix'] is too short
        From schema: Documentation/devicetree/bindings/display/fsl,lcdif.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index b7f296fe5bb8c..813fd85657f6b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -550,8 +550,10 @@ lcdif: lcd-controller@30320000 {
 				compatible = "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif";
 				reg = <0x30320000 0x10000>;
 				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
-				clock-names = "pix";
+				clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
+					 <&clk IMX8MQ_CLK_DISP_APB_ROOT>,
+					 <&clk IMX8MQ_CLK_DISP_AXI_ROOT>;
+				clock-names = "pix", "axi", "disp_axi";
 				assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
 						  <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
 						  <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
-- 
2.34.1

[PATCH 3/3] arm64: dts: imx8mq: Add missing pci property

[Alexander Stein]

Add the required bus-range property to PCI RC node. Fixes the warning:
pcie@33c00000: 'bus-range' is a required property
  From schema: Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 813fd85657f6b..b53592df94b59 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1579,6 +1579,7 @@ pcie1: pcie@33c00000 {
 			#address-cells = <3>;
 			#size-cells = <2>;
 			device_type = "pci";
+			bus-range = <0x00 0xff>;
 			ranges =  <0x81000000 0 0x00000000 0x27f80000 0 0x00010000>, /* downstream I/O 64KB */
 				  <0x82000000 0 0x20000000 0x20000000 0 0x07f00000>; /* non-prefetchable memory */
 			num-lanes = <1>;
-- 
2.34.1

Re: [PATCH 0/3] imx8mq DT fixes

[Fabio Estevam]

On Tue, Jun 6, 2023 at 12:09 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Hi,
>
> this series fixes various dtbs_check warnings for imx8mq.
> Admittedly I do not know why lcdif is currently usable without apb and axi
> clocks configured.
>
> Best regards,
> Alexander
>
> Alexander Stein (3):
>   arm64: dts: imx8mq: Fix lcdif compatible
>   arm64: dts: imx8mq: Fix lcdif clocks
>   arm64: dts: imx8mq: Add missing pci property

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH 0/3] imx8mq DT fixes

[Shawn Guo]

On Tue, Jun 06, 2023 at 05:09:16PM +0200, Alexander Stein wrote:
> Hi,
> 
> this series fixes various dtbs_check warnings for imx8mq.
> Admittedly I do not know why lcdif is currently usable without apb and axi
> clocks configured.
> 
> Best regards,
> Alexander
> 
> Alexander Stein (3):
>   arm64: dts: imx8mq: Fix lcdif compatible
>   arm64: dts: imx8mq: Fix lcdif clocks
>   arm64: dts: imx8mq: Add missing pci property

Applied all, thanks!