[PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

[PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

[Tim Harvey]

Remove the unnecessary #address-cells and #size-cells nodes from
the fan-controller. These are not needed as the fan controller does not
have any children.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
v2:
 - udpated commit log to explain why the nodes are unnessesary
 - added Krzysztof's rb tag
 - added Connor's ab tag
---
 .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
index acb9c54942d9..dc379f3ebf24 100644
--- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
+++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
@@ -122,12 +122,6 @@ patternProperties:
       compatible:
         const: gw,gsc-fan
 
-      "#address-cells":
-        const: 1
-
-      "#size-cells":
-        const: 0
-
       reg:
         description: The fan controller base address
         maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
     required:
       - compatible
       - reg
-      - "#address-cells"
-      - "#size-cells"
 
 required:
   - compatible
@@ -194,8 +186,6 @@ examples:
             };
 
             fan-controller@2c {
-                #address-cells = <1>;
-                #size-cells = <0>;
                 compatible = "gw,gsc-fan";
                 reg = <0x2c>;
             };
-- 
2.25.1

[PATCH v2 2/4] arm64: dts: imx8mm-venice-gw700x: remove invalid props from fan-controller

[Tim Harvey]

Remove the invalid #address-cells and #size-cells nodes from
the fan-controller.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: update commit log
---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
index 9e7d38872157..72cf250d9b4f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
@@ -234,8 +234,6 @@ channel@a2 {
 		};
 
 		fan-controller@0 {
-			#address-cells = <1>;
-			#size-cells = <0>;
 			compatible = "gw,gsc-fan";
 			reg = <0x0a>;
 		};
-- 
2.25.1

Re: [PATCH v2 2/4] arm64: dts: imx8mm-venice-gw700x: remove invalid props from fan-controller

[Shawn Guo]

On Mon, May 22, 2023 at 12:32:17PM -0700, Tim Harvey wrote:
> Remove the invalid #address-cells and #size-cells nodes from
> the fan-controller.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Applied 2/4, 3/4 and 4/4, thanks!

[PATCH v2 3/4] ARM: dts: imx6qdl-gw54xx: remove invalid nodes from fan-controller

[Tim Harvey]

Remove the invalid #address-cells and #size-cells nodes from
the fan-controller.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: new patch
---
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 4e20cb97058e..6c487d40a3b7 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -349,8 +349,6 @@ channel@26 {
 
 		fan-controller@2c {
 			compatible = "gw,gsc-fan";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0x2c>;
 		};
 	};
-- 
2.25.1

[PATCH v2 4/4] ARM: dts: imx6qdl-gw5912: remove invalid nodes from fan-controller

[Tim Harvey]

Remove the invalid #address-cells and #size-cells nodes from
the fan-controller.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: new patch
---
 arch/arm/boot/dts/imx6qdl-gw5912.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi
index 40e235e315cc..de5983cf7810 100644
--- a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi
@@ -243,8 +243,6 @@ channel@23 {
 
 		fan-controller@a {
 			compatible = "gw,gsc-fan";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0x0a>;
 		};
 	};
-- 
2.25.1

Re: [PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

[Rob Herring]

On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller. These are not needed as the fan controller does not
> have any children.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v2:
>  - udpated commit log to explain why the nodes are unnessesary
>  - added Krzysztof's rb tag
>  - added Connor's ab tag
> ---
>  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
>  1 file changed, 10 deletions(-)

This is not going to get applied if you don't send it to Lee.

> 
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index acb9c54942d9..dc379f3ebf24 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -122,12 +122,6 @@ patternProperties:
>        compatible:
>          const: gw,gsc-fan
>  
> -      "#address-cells":
> -        const: 1
> -
> -      "#size-cells":
> -        const: 0
> -
>        reg:
>          description: The fan controller base address
>          maxItems: 1
> @@ -135,8 +129,6 @@ patternProperties:
>      required:
>        - compatible
>        - reg
> -      - "#address-cells"
> -      - "#size-cells"
>  
>  required:
>    - compatible
> @@ -194,8 +186,6 @@ examples:
>              };
>  
>              fan-controller@2c {
> -                #address-cells = <1>;
> -                #size-cells = <0>;
>                  compatible = "gw,gsc-fan";
>                  reg = <0x2c>;
>              };
> -- 
> 2.25.1
> 

Re: [PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

[Tim Harvey]

On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote:
> > Remove the unnecessary #address-cells and #size-cells nodes from
> > the fan-controller. These are not needed as the fan controller does not
> > have any children.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > v2:
> >  - udpated commit log to explain why the nodes are unnessesary
> >  - added Krzysztof's rb tag
> >  - added Connor's ab tag
> > ---
> >  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
> >  1 file changed, 10 deletions(-)
>
> This is not going to get applied if you don't send it to Lee.

Lee,

Sorry, I missed adding you to this thread. Can you pick it up or do
you need me to re-send to the list and you?

Best Regards,

Tim

>
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > index acb9c54942d9..dc379f3ebf24 100644
> > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > @@ -122,12 +122,6 @@ patternProperties:
> >        compatible:
> >          const: gw,gsc-fan
> >
> > -      "#address-cells":
> > -        const: 1
> > -
> > -      "#size-cells":
> > -        const: 0
> > -
> >        reg:
> >          description: The fan controller base address
> >          maxItems: 1
> > @@ -135,8 +129,6 @@ patternProperties:
> >      required:
> >        - compatible
> >        - reg
> > -      - "#address-cells"
> > -      - "#size-cells"
> >
> >  required:
> >    - compatible
> > @@ -194,8 +186,6 @@ examples:
> >              };
> >
> >              fan-controller@2c {
> > -                #address-cells = <1>;
> > -                #size-cells = <0>;
> >                  compatible = "gw,gsc-fan";
> >                  reg = <0x2c>;
> >              };
> > --
> > 2.25.1
> >

Re: [PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

[Lee Jones]

On Fri, 09 Jun 2023, Tim Harvey wrote:

> On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote:
> > > Remove the unnecessary #address-cells and #size-cells nodes from
> > > the fan-controller. These are not needed as the fan controller does not
> > > have any children.
> > >
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > ---
> > > v2:
> > >  - udpated commit log to explain why the nodes are unnessesary
> > >  - added Krzysztof's rb tag
> > >  - added Connor's ab tag
> > > ---
> > >  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
> > >  1 file changed, 10 deletions(-)
> >
> > This is not going to get applied if you don't send it to Lee.
> 
> Lee,
> 
> Sorry, I missed adding you to this thread. Can you pick it up or do
> you need me to re-send to the list and you?

I need you to resend it please.

-- 
Lee Jones [李琼斯]