From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A54CEC7EE2E
	for <linux-devicetree@archiver.kernel.org>; Fri,  9 Jun 2023 20:52:56 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231630AbjFIUwy (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Fri, 9 Jun 2023 16:52:54 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48258 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230090AbjFIUwx (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Fri, 9 Jun 2023 16:52:53 -0400
Received: from mail-40130.protonmail.ch (mail-40130.protonmail.ch [185.70.40.130])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEE5930FC
        for <devicetree@vger.kernel.org>; Fri,  9 Jun 2023 13:52:52 -0700 (PDT)
Date:   Fri, 09 Jun 2023 20:52:47 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
        s=protonmail3; t=1686343970; x=1686603170;
        bh=He8yZMV2kI8DEJFeHkiOpD6I4kpbWyGVezca/gfNczU=;
        h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
         Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
         Message-ID:BIMI-Selector;
        b=ZnXS7fHEsgjdPBDSqfMRmtKVAKvHqYiJOovmcJinFKhD+Qe881bRtyJ2yx9rGl4xE
         doy99lYaqjtNQzsyll1qciZtgHDfIeL7o6kyxtrqMyjSmePiPK8eX7D9pMCD9C8XEc
         kIhuGElfd4EK025NFCweSwgmW7XvbZQ6tbHsKG9RL9WZGJrvct9yfMb7poq0s0P//t
         piYx408ZmpvOYIuRSqLwHKRNyCwD9Iazhfu3o3zYK/zHZpItX+IdI+xZrm3514rsCY
         OgWOFzqr3O0YpzbMPVA9j8FqUH+jDH7oF8fJ8GAfNEyd2WIqhq41nhK1uhZQbjlLpQ
         XbmLZDaGv2Kbg==
To:     broonie@kernel.org
From:   Raymond Hackley <raymondhackley@protonmail.com>
Cc:     davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, jk@codeconstruct.com.au,
        krzysztof.kozlowski@linaro.org, kuba@kernel.org,
        lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        michael@walle.cc, netdev@vger.kernel.org, pabeni@redhat.com,
        raymondhackley@protonmail.com, robh+dt@kernel.org,
        u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply
Message-ID: <20230609205227.105306-1-raymondhackley@protonmail.com>
In-Reply-To: <a3d2dd4f-38ce-40ca-9085-893f808f817b@sirena.org.uk>
References: <20230609154033.3511-1-raymondhackley@protonmail.com> <20230609154200.3620-1-raymondhackley@protonmail.com> <e2bb439c-9b72-991b-00f6-0b5e7602efd9@linaro.org> <20230609173935.84424-1-raymondhackley@protonmail.com> <7ad5d027-9b15-f59e-aa76-17e498cb7aba@linaro.org> <a3d2dd4f-38ce-40ca-9085-893f808f817b@sirena.org.uk>
Feedback-ID: 49437091:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

Hi Mark,

On Friday, June 9th, 2023 at 7:34 PM, Mark Brown <broonie@kernel.org> wrote=
:
=20
> Specifically your driver should only ever call regulator_disable() to
> balance out regulator_enable() calls it made itself and it should know
> how many of those it has done. regulator_is_enabled() should only ever
> be used during probe if for some reason it is important to figure out if
> the device is already powered for startup, this should be very unusual.
> If something else enabled the regualtor then whatever did that needs to
> undo those enables, not another driver.

Thnak you for explanation. I should drop regulator_is_enabled() here since
it's misused.

Regards,
Raymond