[PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
@ 2023-06-09 14:07 Krzysztof Kozlowski
  2023-06-09 19:10 ` Linus Walleij
  2023-06-09 22:54 ` Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-09 14:07 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Linus Walleij, linux-crypto, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Cleanup bindings dropping unneeded quotes. Once all these are fixed,
checking for this can be enabled in yamllint.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml b/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml
index e0fe63957888..8e2d95d732ba 100644
--- a/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml
@@ -21,7 +21,7 @@ properties:
     const: intel,ixp4xx-crypto
 
   intel,npe-handle:
-    $ref: '/schemas/types.yaml#/definitions/phandle-array'
+    $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
       - items:
           - description: phandle to the NPE this crypto engine
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
  2023-06-09 14:07 [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes Krzysztof Kozlowski
@ 2023-06-09 19:10 ` Linus Walleij
  2023-06-09 22:54 ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2023-06-09 19:10 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-crypto, devicetree, linux-kernel

On Fri, Jun 9, 2023 at 4:07 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
  2023-06-09 14:07 [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes Krzysztof Kozlowski
  2023-06-09 19:10 ` Linus Walleij
@ 2023-06-09 22:54 ` Rob Herring
  2023-06-21  6:40   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-06-09 22:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Herbert Xu, David S. Miller, Krzysztof Kozlowski, Conor Dooley,
	Linus Walleij, linux-crypto, devicetree, linux-kernel

On Fri, Jun 09, 2023 at 04:07:45PM +0200, Krzysztof Kozlowski wrote:
> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You missed $id and $schema values.

Within drivers/crypto, there's also:

diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bi
ndings/crypto/amlogic,gxl-crypto.yaml
index ecf98a9e72b2..948e11ebe4ee 100644
--- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
@@ -19,8 +19,8 @@ properties:
 
   interrupts:
     items:
-      - description: "Interrupt for flow 0"
-      - description: "Interrupt for flow 1"
+      - description: Interrupt for flow 0
+      - description: Interrupt for flow 1
 
   clocks:
     maxItems: 1

Can you add this in here. No reason to split this up more that 1 patch 
per subsystem really. 

As I mentioned, I have a WIP tree[1] with yamllint checks enabled and 
I scripted many of the changes. It was clean, but there's some new ones 
since rebasing to v6.4-rc1:

../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:30:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:31:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:42:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:43:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:38:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:39:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:40:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:41:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:42:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:43:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:34:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:35:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:36:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:37:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:65:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:74:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:83:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:93:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:117:15: [error] string value is redundantly quoted with any quotes (quoted-strings)

Rob

[1] https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/log/?h=dt/yamllint

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
  2023-06-09 22:54 ` Rob Herring
@ 2023-06-21  6:40   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-21  6:40 UTC (permalink / raw)
  To: Rob Herring
  Cc: Herbert Xu, David S. Miller, Krzysztof Kozlowski, Conor Dooley,
	Linus Walleij, linux-crypto, devicetree, linux-kernel

On 10/06/2023 00:54, Rob Herring wrote:
> On Fri, Jun 09, 2023 at 04:07:45PM +0200, Krzysztof Kozlowski wrote:
>> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
>> checking for this can be enabled in yamllint.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml         | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> You missed $id and $schema values.
> 
> Within drivers/crypto, there's also:
> 
> diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bi
> ndings/crypto/amlogic,gxl-crypto.yaml
> index ecf98a9e72b2..948e11ebe4ee 100644
> --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> @@ -19,8 +19,8 @@ properties:
>  
>    interrupts:
>      items:
> -      - description: "Interrupt for flow 0"
> -      - description: "Interrupt for flow 1"
> +      - description: Interrupt for flow 0
> +      - description: Interrupt for flow 1
>  
>    clocks:
>      maxItems: 1
> 
> Can you add this in here. No reason to split this up more that 1 patch 
> per subsystem really. 

I'll add it. I am also fine for you to squash it or take your scripted
changes/commit if you have it ready.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-21  6:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 14:07 [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes Krzysztof Kozlowski
2023-06-09 19:10 ` Linus Walleij
2023-06-09 22:54 ` Rob Herring
2023-06-21  6:40   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).