From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01639C7EE37 for ; Sat, 10 Jun 2023 22:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbjFJWRo (ORCPT ); Sat, 10 Jun 2023 18:17:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbjFJWRn (ORCPT ); Sat, 10 Jun 2023 18:17:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ADC335A9; Sat, 10 Jun 2023 15:17:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F085B61B3B; Sat, 10 Jun 2023 22:17:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F1D3C433EF; Sat, 10 Jun 2023 22:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686435461; bh=iPCNRHIK3Pj5zhVltUCKRZCkjsC5p0Cp7eGGBoVlFUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mcV/L+4qbM/r3gE394dVVDAhi7j1GmgOpTn9nPsaSlM2HjceDm/1/8qu7vSAM8W3h ghJhSzA0xY2vVTtDOQSm/LHFvpyPFRloIgvCrt0ucQR9A25b/BgQsfVxhoRmB3kFZJ pX1yjkK99Wgaxlcigw6PDSzzncRxNWFbUDeJTZbC3DMh8n9t/vLEZGJYh8er5oJKY3 StxCgC74J8W21eAQr0kb1tHEtXfio8eW/gbSUL75XhRoasU0joGxKQZc4fXdA4DkEk QlFJLlLE9Q4FRFongl4R5tujxb3S5Zp5JieNIAmJOlzMwzikMaC5VEQryjFO5/69Ij TS8msKVKdKvEQ== Date: Sat, 10 Jun 2023 23:17:32 +0100 From: Conor Dooley To: Maksim Kiselev Cc: linux-iio@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , Heiko Stuebner , Andy Shevchenko , Cosmin Tanislav , Hugo Villeneuve , Ulf Hansson , Arnd Bergmann , ChiaEn Wu , Ibrahim Tilki , ChiYuan Huang , Ramona Bolboaca , William Breathitt Gray , Leonard =?iso-8859-1?Q?G=F6hrs?= , Caleb Connolly , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 2/3] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC Message-ID: <20230610-thinner-sector-795141d97f40@spud> References: <20230610202005.1118049-1-bigunclemax@gmail.com> <20230610202005.1118049-3-bigunclemax@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SGD9UZV1OU3mbFIW" Content-Disposition: inline In-Reply-To: <20230610202005.1118049-3-bigunclemax@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --SGD9UZV1OU3mbFIW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 10, 2023 at 11:19:49PM +0300, Maksim Kiselev wrote: > From: Maxim Kiselev >=20 > Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC. > This ADC is the same for all of this SoCs. The only difference is > the number of available channels. >=20 > Signed-off-by: Maxim Kiselev Looks fine to me chief. Reviewed-by: Conor Dooley > --- > .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 91 +++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,s= un20i-d1-gpadc.yaml >=20 > diff --git a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d= 1-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d= 1-gpadc.yaml > new file mode 100644 > index 000000000000..43256ad2b7ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc= =2Eyaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/allwinner,sun20i-d1-gpadc.yam= l# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner D1 General Purpose ADC > + > +maintainers: > + - Maksim Kiselev > + > +properties: > + compatible: > + enum: > + - allwinner,sun20i-d1-gpadc btw, do you intend coming along later and adding some of the other ones, or do you only have the d1 yourself? Cheers, Conor. --SGD9UZV1OU3mbFIW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIT2fAAKCRB4tDGHoIJi 0vPXAP9aQLXN+V9qv4WJvylU1e1YEs5nQZv59+ccPZXpauxUFAD6ApBn6gx6uIwZ WyzNup+1zJrn+/u59jc7JlHJQrKtzQQ= =c3Gc -----END PGP SIGNATURE----- --SGD9UZV1OU3mbFIW--