* [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning
@ 2023-06-10 12:22 Shreeya Patel
2023-06-10 12:56 ` Heiko Stübner
0 siblings, 1 reply; 2+ messages in thread
From: Shreeya Patel @ 2023-06-10 12:22 UTC (permalink / raw)
To: jic23, lars, robh+dt, krzysztof.kozlowski+dt, conor+dt, heiko,
sebastian.reichel
Cc: linux-iio, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, kernel, gustavo.padovan, serge.broslavsky,
Shreeya Patel
Fix the dtbs_check warning for 'oneOf' condition failure.
DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
/home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
saradc@fec10000: compatible: 'oneOf' conditional failed,
one must be fixed:
['rockchip,rk3588-saradc'] is too short
'rockchip,saradc' was expected
'rockchip,rk3066-tsadc' was expected
'rockchip,rk3399-saradc' was expected
Fixes: 2daf2ae9793d ("dt-bindings: iio: adc: Add rockchip,rk3588-saradc string")
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
---
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index 11c27ea451c8..aa24b841393c 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -15,13 +15,13 @@ properties:
- const: rockchip,saradc
- const: rockchip,rk3066-tsadc
- const: rockchip,rk3399-saradc
+ - const: rockchip,rk3588-saradc
- items:
- enum:
- rockchip,px30-saradc
- rockchip,rk3308-saradc
- rockchip,rk3328-saradc
- rockchip,rk3568-saradc
- - rockchip,rk3588-saradc
- rockchip,rv1108-saradc
- rockchip,rv1126-saradc
- const: rockchip,rk3399-saradc
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning
2023-06-10 12:22 [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning Shreeya Patel
@ 2023-06-10 12:56 ` Heiko Stübner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2023-06-10 12:56 UTC (permalink / raw)
To: jic23, lars, robh+dt, krzysztof.kozlowski+dt, conor+dt,
sebastian.reichel, Shreeya Patel
Cc: linux-iio, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, kernel, gustavo.padovan, serge.broslavsky,
Shreeya Patel
Am Samstag, 10. Juni 2023, 14:22:00 CEST schrieb Shreeya Patel:
> Fix the dtbs_check warning for 'oneOf' condition failure.
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
> /home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
> saradc@fec10000: compatible: 'oneOf' conditional failed,
> one must be fixed:
> ['rockchip,rk3588-saradc'] is too short
> 'rockchip,saradc' was expected
> 'rockchip,rk3066-tsadc' was expected
> 'rockchip,rk3399-saradc' was expected
>
Nit: the commit message could explain that the rk3588 in fact isn't
compatible with the rk3399-saradc variant.
Otherwise I checked the implementation, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Fixes: 2daf2ae9793d ("dt-bindings: iio: adc: Add rockchip,rk3588-saradc string")
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 11c27ea451c8..aa24b841393c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -15,13 +15,13 @@ properties:
> - const: rockchip,saradc
> - const: rockchip,rk3066-tsadc
> - const: rockchip,rk3399-saradc
> + - const: rockchip,rk3588-saradc
> - items:
> - enum:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> - rockchip,rk3568-saradc
> - - rockchip,rk3588-saradc
> - rockchip,rv1108-saradc
> - rockchip,rv1126-saradc
> - const: rockchip,rk3399-saradc
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-10 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 12:22 [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning Shreeya Patel
2023-06-10 12:56 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).