From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Shreeya Patel <shreeya.patel@collabora.com>,
lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
heiko@sntech.de, sebastian.reichel@collabora.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, gustavo.padovan@collabora.com,
serge.broslavsky@collabora.com
Subject: Re: [PATCH v2] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning
Date: Sat, 10 Jun 2023 19:06:55 +0100 [thread overview]
Message-ID: <20230610190655.5f3427a3@jic23-huawei> (raw)
In-Reply-To: <c5243179-9baf-59ce-b979-c596dcf6692b@linaro.org>
On Sat, 10 Jun 2023 18:30:57 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 10/06/2023 16:36, Shreeya Patel wrote:
> > rk3588-saradc isn't compatible with the rk3399-saradc variant,
> > hence, fix the following dtbs_check warning for 'oneOf' condition
> > failure.
> >
>
> Are you sure it isn't compatible? According to your driver it is and
> this change is not enough.
I'm not following. the rk3588 has separate handling from the rk3399
Separate devices specific structure for instance
rk3588_saradc_data vs rk3399_saradc_data as provided as the match data for
the different compatibles..
Looks to be incompatible to me.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-06-10 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 14:36 [PATCH v2] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning Shreeya Patel
2023-06-10 15:07 ` Conor Dooley
2023-06-10 16:30 ` Krzysztof Kozlowski
2023-06-10 17:11 ` Sebastian Reichel
2023-06-10 17:34 ` Krzysztof Kozlowski
2023-06-10 18:24 ` Jonathan Cameron
2023-06-10 18:06 ` Jonathan Cameron [this message]
2023-06-12 9:44 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610190655.5f3427a3@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox