From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B60BC7EE43 for ; Mon, 12 Jun 2023 20:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjFLUmR (ORCPT ); Mon, 12 Jun 2023 16:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234509AbjFLUld (ORCPT ); Mon, 12 Jun 2023 16:41:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F4101732 for ; Mon, 12 Jun 2023 13:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686602447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+GICplP/MT1isAH+ok2l+9fKNc3rvvMZkj74HkVOtyg=; b=HZb4b7DF1KJD+PD54kOwh8oUXEN1DjN5oyTSoWWcoM6dThxgpjpqgck3J0C9KGjIjAVmWZ mWYjyoVs4f74U5YyY4goTjMRDrA7UGAwGy9fIuZ0xQsM1Lalgp4JHNLWo7AQWNLba/niJz 5Pz08+6aFVkjq1SjCGYDIcltIG/dGLA= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-MC77pT2QOJiOxgal1HD37w-1; Mon, 12 Jun 2023 16:40:46 -0400 X-MC-Unique: MC77pT2QOJiOxgal1HD37w-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-56cea71b98fso39094447b3.0 for ; Mon, 12 Jun 2023 13:40:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686602445; x=1689194445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+GICplP/MT1isAH+ok2l+9fKNc3rvvMZkj74HkVOtyg=; b=OFYP6fWh0+DBdBg3lf9yHdufhrRdm5MhM+w068AI2Pdc9jubbLaZRqTjr/j1eotku1 6mXzTQoLq69X+MxcokXC/ABENzEf92eH8nQZuyJhQEFyGbsR4TLvMcAZRpTVkU32ZH79 XQREw15b/AVy9HWu+hMnMHn3wM2MazZrx72YxTQmRifIWH4kb3+/hNVHBY/K7JYzMlyQ MrBwEfu9t4xuqgf0rWsGPltABIklLeEjJvv0CjcLvl9rPto/amUcd3ir5rz5wG/2a3K4 FrE06CPv7zIjT38+x3yKpd8YT4QJl+ByU/odl/9HuYkXyXksa9aQKyj2YF4qzdT5TeWA UEpw== X-Gm-Message-State: AC+VfDwP2J8//YnAsdrgUn3HBPwF2PfYDyF8WIpETXozp2h9e0vHi0km 5vqnuJ9j86G99c/UHkesx2hDLGWqvnUAmgtwKZ8W+AhyX2EK5UQ4KtvDvQIJF768ojJub4kctYC pVUGWojnSSdRxNDRIVkvWMQ== X-Received: by 2002:a0d:d3c5:0:b0:569:770d:c9be with SMTP id v188-20020a0dd3c5000000b00569770dc9bemr12009515ywd.41.1686602445481; Mon, 12 Jun 2023 13:40:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5YAuKjyJv/dyosgPSnG9gP4AwJix4ti1YXmUnmzQLCn8a2Fe9vENV68IYdOSwyVmtTplKXgA== X-Received: by 2002:a0d:d3c5:0:b0:569:770d:c9be with SMTP id v188-20020a0dd3c5000000b00569770dc9bemr12009500ywd.41.1686602445225; Mon, 12 Jun 2023 13:40:45 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::45]) by smtp.gmail.com with ESMTPSA id k190-20020a0dc8c7000000b0056d51c39c1fsm208496ywd.23.2023.06.12.13.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 13:40:44 -0700 (PDT) Date: Mon, 12 Jun 2023 15:40:42 -0500 From: Andrew Halaney To: Bartosz Golaszewski Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski Subject: Re: [PATCH 13/26] net: stmmac: dwmac-qcom-ethqos: make the rgmii clock optional Message-ID: <20230612204042.litbbv23zdb3u5k7@halaney-x13s> References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-14-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612092355.87937-14-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jun 12, 2023 at 11:23:42AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > On sa8775p there's no RGMII clock so make it optional in the driver. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 3438b6229351..252dca400071 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -663,7 +663,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > ethqos->rgmii_config_loopback_en = data->rgmii_config_loopback_en; > ethqos->has_emac3 = data->has_emac3; > > - ethqos->rgmii_clk = devm_clk_get(dev, "rgmii"); > + ethqos->rgmii_clk = devm_clk_get_optional(dev, "rgmii"); This makes it optional for older platforms too, but as far as I know on those platforms it is mandatory. This can be enforced in dt-binding checks, but should we also enforce that in the driver still? Honestly I feel like yes, but there's probably some precedent maintainers follow on this front that I don't know of. > if (IS_ERR(ethqos->rgmii_clk)) { > ret = PTR_ERR(ethqos->rgmii_clk); > goto out_config_dt; > -- > 2.39.2 >