From: Herve Codina <herve.codina@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 11/12] ASoC: codecs: Add support for the generic IIO auxiliary devices
Date: Tue, 13 Jun 2023 11:37:07 +0200 [thread overview]
Message-ID: <20230613113707.0b5d9648@bootlin.com> (raw)
In-Reply-To: <CAHp75Vfz+vSJ7rQ4sxb0R+zRbrjipXUX3VpaHyvOWWePdPxejQ@mail.gmail.com>
Hi Andy,
On Mon, 12 Jun 2023 17:37:00 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> ...
>
> > + struct snd_kcontrol_new control = {0};
>
> 0 is not needed.
Not for this one.
The variable is in stack.
Some of the structure members will be set in the code but we need to ensure
that all others are set to 0.
The full context:
--- 8< ---
static int audio_iio_aux_add_controls(struct snd_soc_component *component,
struct audio_iio_aux_chan *chan)
{
struct snd_kcontrol_new control = {0};
control.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
control.name = chan->name;
control.info = audio_iio_aux_info_volsw;
control.get = audio_iio_aux_get_volsw;
control.put = audio_iio_aux_put_volsw;
control.private_value = (unsigned long)chan;
return snd_soc_add_component_controls(component, &control, 1);
}
--- 8< ---
Thanks for the review,
Hervé
next prev parent reply other threads:[~2023-06-13 9:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 12:29 [PATCH v3 00/12] Add support for IIO devices in ASoC Herve Codina
2023-06-12 12:29 ` [PATCH v3 01/12] ASoC: dt-bindings: Add audio-iio-aux Herve Codina
2023-06-12 12:29 ` [PATCH v3 02/12] ASoC: dt-bindings: simple-card: Add additional-devs subnode Herve Codina
2023-06-12 12:29 ` [PATCH v3 03/12] iio: inkern: Check error explicitly in iio_channel_read_max() Herve Codina
2023-06-12 14:04 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 04/12] iio: consumer.h: Fix raw values documentation notes Herve Codina
2023-06-12 14:16 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 05/12] iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() Herve Codina
2023-06-12 14:05 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 06/12] minmax: Introduce {min,max}_array() Herve Codina
2023-06-12 14:10 ` Andy Shevchenko
2023-06-13 8:00 ` Herve Codina
2023-06-13 17:08 ` Andy Shevchenko
2023-06-13 17:34 ` Herve Codina
2023-06-12 12:29 ` [PATCH v3 07/12] iio: inkern: Use max_array() to get the maximum value from an array Herve Codina
2023-06-12 14:12 ` Andy Shevchenko
2023-06-12 14:13 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 08/12] iio: inkern: Replace a FIXME comment by a TODO one Herve Codina
2023-06-12 14:14 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 09/12] iio: inkern: Add a helper to query an available minimum raw value Herve Codina
2023-06-12 14:15 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 10/12] ASoC: soc-dapm.h: Convert macros to return a compound litteral Herve Codina
2023-06-12 14:23 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 11/12] ASoC: codecs: Add support for the generic IIO auxiliary devices Herve Codina
2023-06-12 14:37 ` Andy Shevchenko
2023-06-13 9:37 ` Herve Codina [this message]
2023-06-13 13:24 ` Andy Shevchenko
2023-06-13 13:55 ` Herve Codina
2023-06-12 12:29 ` [PATCH v3 12/12] ASoC: simple-card: Handle additional devices Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613113707.0b5d9648@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).