From: Herve Codina <herve.codina@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 06/12] minmax: Introduce {min,max}_array()
Date: Tue, 13 Jun 2023 19:34:40 +0200 [thread overview]
Message-ID: <20230613193440.1940c3a7@bootlin.com> (raw)
In-Reply-To: <CAHp75Vcr5Owjn0HK-+D0mpPJAkAxG7F8bEO=sqvhT8w=_xnF7w@mail.gmail.com>
On Tue, 13 Jun 2023 20:08:08 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Jun 13, 2023 at 11:00 AM Herve Codina <herve.codina@bootlin.com> wrote:
> > On Mon, 12 Jun 2023 17:10:40 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Mon, Jun 12, 2023 at 3:30 PM Herve Codina <herve.codina@bootlin.com> wrote:
> > > >
> > > > Introduce min_array() (resp max_array()) in order to get the
> > > > minimal (resp maximum) of values present in an array.
> > >
> > > Some comments below, after addressing them,
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> ...
>
> > > > + typeof(array) __array = (array); \
> > >
> > > We have __must_be_array()
> >
> > Using __must_be_array() will lead to some failure.
> > Indeed, we can have:
> > --- 8< ---
> > int *buff
> > ...
> > min = min_array(buff, nb_item);
> > --- 8< ---
> >
> > In this case, __must_be_array() will report that buff is not an array.
>
> Oh, I missed that.
>
> > To avoid any confusion, what do you think if I renamed {min,max}_array()
> > to {min,max}_buffer() and replace __array by __buff and use *(__buff + xxx)
> > instead of array[xxx] in the macro.
>
> But functionally it's still against an array.
>
> I would stick with "array" in the name, but add a comment why
> __must_be_array() is not used. If we need a stricter variant, we may
> add a new wrapper with that check. That said, I think we can use
> __array[0] and similar indexed accesses.
>
Right, I will provide an updated version on the next iteration.
Thanks for your feedback.
Hervé
next prev parent reply other threads:[~2023-06-13 17:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 12:29 [PATCH v3 00/12] Add support for IIO devices in ASoC Herve Codina
2023-06-12 12:29 ` [PATCH v3 01/12] ASoC: dt-bindings: Add audio-iio-aux Herve Codina
2023-06-12 12:29 ` [PATCH v3 02/12] ASoC: dt-bindings: simple-card: Add additional-devs subnode Herve Codina
2023-06-12 12:29 ` [PATCH v3 03/12] iio: inkern: Check error explicitly in iio_channel_read_max() Herve Codina
2023-06-12 14:04 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 04/12] iio: consumer.h: Fix raw values documentation notes Herve Codina
2023-06-12 14:16 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 05/12] iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() Herve Codina
2023-06-12 14:05 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 06/12] minmax: Introduce {min,max}_array() Herve Codina
2023-06-12 14:10 ` Andy Shevchenko
2023-06-13 8:00 ` Herve Codina
2023-06-13 17:08 ` Andy Shevchenko
2023-06-13 17:34 ` Herve Codina [this message]
2023-06-12 12:29 ` [PATCH v3 07/12] iio: inkern: Use max_array() to get the maximum value from an array Herve Codina
2023-06-12 14:12 ` Andy Shevchenko
2023-06-12 14:13 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 08/12] iio: inkern: Replace a FIXME comment by a TODO one Herve Codina
2023-06-12 14:14 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 09/12] iio: inkern: Add a helper to query an available minimum raw value Herve Codina
2023-06-12 14:15 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 10/12] ASoC: soc-dapm.h: Convert macros to return a compound litteral Herve Codina
2023-06-12 14:23 ` Andy Shevchenko
2023-06-12 12:29 ` [PATCH v3 11/12] ASoC: codecs: Add support for the generic IIO auxiliary devices Herve Codina
2023-06-12 14:37 ` Andy Shevchenko
2023-06-13 9:37 ` Herve Codina
2023-06-13 13:24 ` Andy Shevchenko
2023-06-13 13:55 ` Herve Codina
2023-06-12 12:29 ` [PATCH v3 12/12] ASoC: simple-card: Handle additional devices Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613193440.1940c3a7@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).