* Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"
2023-06-13 20:11 [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep" Rob Herring
@ 2023-06-13 20:20 ` Andrew Lunn
2023-06-13 20:51 ` Peter Korsgaard
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-06-13 20:20 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Korsgaard, Krzysztof Kozlowski, Conor Dooley, linux-i2c,
devicetree, linux-kernel
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"
2023-06-13 20:11 [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep" Rob Herring
2023-06-13 20:20 ` Andrew Lunn
@ 2023-06-13 20:51 ` Peter Korsgaard
2023-06-13 20:54 ` Conor Dooley
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2023-06-13 20:51 UTC (permalink / raw)
To: Rob Herring
Cc: Andrew Lunn, Krzysztof Kozlowski, Conor Dooley, linux-i2c,
devicetree, linux-kernel
>>>>> "Rob" == Rob Herring <robh@kernel.org> writes:
> "regstep" may be deprecated, but it still needs a type.
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> index 85d9efb743ee..d9ef86729011 100644
> --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> @@ -60,6 +60,7 @@ properties:
> default: 0
> regstep:
> + $ref: /schemas/types.yaml#/definitions/uint32
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"
2023-06-13 20:11 [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep" Rob Herring
2023-06-13 20:20 ` Andrew Lunn
2023-06-13 20:51 ` Peter Korsgaard
@ 2023-06-13 20:54 ` Conor Dooley
2023-06-14 0:31 ` Andi Shyti
2023-06-14 8:33 ` Wolfram Sang
4 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-06-13 20:54 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Korsgaard, Andrew Lunn, Krzysztof Kozlowski, Conor Dooley,
linux-i2c, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
Mea culpa!
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> index 85d9efb743ee..d9ef86729011 100644
> --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> @@ -60,6 +60,7 @@ properties:
> default: 0
>
> regstep:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description: |
> deprecated, use reg-shift above
> deprecated: true
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"
2023-06-13 20:11 [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep" Rob Herring
` (2 preceding siblings ...)
2023-06-13 20:54 ` Conor Dooley
@ 2023-06-14 0:31 ` Andi Shyti
2023-06-14 8:33 ` Wolfram Sang
4 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2023-06-14 0:31 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Korsgaard, Andrew Lunn, Krzysztof Kozlowski, Conor Dooley,
linux-i2c, devicetree, linux-kernel
Hi Rob,
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"
2023-06-13 20:11 [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep" Rob Herring
` (3 preceding siblings ...)
2023-06-14 0:31 ` Andi Shyti
@ 2023-06-14 8:33 ` Wolfram Sang
4 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2023-06-14 8:33 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Korsgaard, Andrew Lunn, Krzysztof Kozlowski, Conor Dooley,
linux-i2c, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Added fixes tag and applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread