* [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"
@ 2023-06-13 20:12 Rob Herring
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Rob Herring @ 2023-06-13 20:12 UTC (permalink / raw)
To: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley
Cc: linux-crypto, devicetree, linux-kernel
The "linux,keycode" property is missing a type probably because it was
confused with the common property "linux,keycodes".
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
index 286dffa0671b..6052129bf852 100644
--- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
@@ -103,6 +103,7 @@ properties:
wakeup-source: true
linux,keycode:
+ $ref: /schemas/types.yaml#/definitions/uint32
default: 116
required:
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
2023-06-13 20:12 [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Rob Herring
@ 2023-06-13 20:12 ` Rob Herring
2023-06-13 21:11 ` Conor Dooley
2023-06-15 17:27 ` Rob Herring
2023-06-13 21:08 ` [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Conor Dooley
2023-06-15 17:27 ` Rob Herring
2 siblings, 2 replies; 8+ messages in thread
From: Rob Herring @ 2023-06-13 20:12 UTC (permalink / raw)
To: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley
Cc: linux-crypto, devicetree, linux-kernel
The "linux,keycode" property is non-standard. Add the common property
"linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
is not propagated.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
index 6052129bf852..e879bc0be8e2 100644
--- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
@@ -105,6 +105,11 @@ properties:
linux,keycode:
$ref: /schemas/types.yaml#/definitions/uint32
default: 116
+ deprecated: true
+
+ linux,keycodes:
+ maxItems: 1
+ default: 116
required:
- compatible
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
@ 2023-06-13 21:11 ` Conor Dooley
2023-06-14 14:53 ` Rob Herring
2023-06-15 17:27 ` Rob Herring
1 sibling, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-06-13 21:11 UTC (permalink / raw)
To: Rob Herring
Cc: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, linux-crypto,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> The "linux,keycode" property is non-standard. Add the common property
> "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> is not propagated.
This is actually used in the driver for this device, should the driver
not also be updated to use the corrected property?
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> index 6052129bf852..e879bc0be8e2 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml
> @@ -105,6 +105,11 @@ properties:
> linux,keycode:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 116
> + deprecated: true
> +
> + linux,keycodes:
> + maxItems: 1
> + default: 116
>
> required:
> - compatible
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
2023-06-13 21:11 ` Conor Dooley
@ 2023-06-14 14:53 ` Rob Herring
2023-06-14 17:26 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2023-06-14 14:53 UTC (permalink / raw)
To: Conor Dooley
Cc: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, linux-crypto,
devicetree, linux-kernel
On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > The "linux,keycode" property is non-standard. Add the common property
> > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > is not propagated.
>
> This is actually used in the driver for this device, should the driver
> not also be updated to use the corrected property?
Yes, but that doesn't have to be in sync with the binding change. I
mainly want to add this so it doesn't get propagated to new users
rather than move this case off of linux,keycode. Also, the input
subsystem should probably have a common function to read
linux,keycodes as right now every driver does it.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
2023-06-14 14:53 ` Rob Herring
@ 2023-06-14 17:26 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-06-14 17:26 UTC (permalink / raw)
To: Rob Herring
Cc: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, linux-crypto,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Wed, Jun 14, 2023 at 08:53:20AM -0600, Rob Herring wrote:
> On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > > The "linux,keycode" property is non-standard. Add the common property
> > > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > > is not propagated.
> >
> > This is actually used in the driver for this device, should the driver
> > not also be updated to use the corrected property?
>
> Yes, but that doesn't have to be in sync with the binding change. I
> mainly want to add this so it doesn't get propagated to new users
> rather than move this case off of linux,keycode. Also, the input
> subsystem should probably have a common function to read
> linux,keycodes as right now every driver does it.
Perhaps one of the nxp folk in the audience should have a crack at that
so.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
2023-06-13 21:11 ` Conor Dooley
@ 2023-06-15 17:27 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-06-15 17:27 UTC (permalink / raw)
To: Rob Herring
Cc: Herbert Xu, linux-crypto, Horia Geantă, Krzysztof Kozlowski,
Gaurav Jain, devicetree, David S. Miller, Pankaj Gupta,
linux-kernel, Conor Dooley
On Tue, 13 Jun 2023 14:12:30 -0600, Rob Herring wrote:
> The "linux,keycode" property is non-standard. Add the common property
> "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> is not propagated.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"
2023-06-13 20:12 [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Rob Herring
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
@ 2023-06-13 21:08 ` Conor Dooley
2023-06-15 17:27 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-06-13 21:08 UTC (permalink / raw)
To: Rob Herring
Cc: Horia Geantă, Pankaj Gupta, Gaurav Jain, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, linux-crypto,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Tue, Jun 13, 2023 at 02:12:29PM -0600, Rob Herring wrote:
> The "linux,keycode" property is missing a type probably because it was
> confused with the common property "linux,keycodes".
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"
2023-06-13 20:12 [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Rob Herring
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
2023-06-13 21:08 ` [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Conor Dooley
@ 2023-06-15 17:27 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-06-15 17:27 UTC (permalink / raw)
To: Rob Herring
Cc: David S. Miller, devicetree, Krzysztof Kozlowski,
Horia Geantă, Herbert Xu, Conor Dooley, Pankaj Gupta,
linux-crypto, linux-kernel, Gaurav Jain
On Tue, 13 Jun 2023 14:12:29 -0600, Rob Herring wrote:
> The "linux,keycode" property is missing a type probably because it was
> confused with the common property "linux,keycodes".
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-06-15 17:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-13 20:12 [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Rob Herring
2023-06-13 20:12 ` [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode" Rob Herring
2023-06-13 21:11 ` Conor Dooley
2023-06-14 14:53 ` Rob Herring
2023-06-14 17:26 ` Conor Dooley
2023-06-15 17:27 ` Rob Herring
2023-06-13 21:08 ` [PATCH 1/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode" Conor Dooley
2023-06-15 17:27 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).