From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5764DEB64D7 for ; Fri, 16 Jun 2023 10:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232372AbjFPKNa (ORCPT ); Fri, 16 Jun 2023 06:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233557AbjFPKN3 (ORCPT ); Fri, 16 Jun 2023 06:13:29 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DBA5AC; Fri, 16 Jun 2023 03:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686910408; x=1718446408; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YpSM1w+IYXXoUKSojagF+UoCf/8hiOK0HsM860yz38E=; b=x8GaDBO93AJNI8beGQfsCylbIlpJpJ1JtTbkYnJJ2VixP1g/c5tHwlEj mwOZMy22M9szW7tj+PWRko9VdMntMEmJFxSQpEQ4Xsni6N08QnyrdPoED whnePP9zBT/opuxDiSo4b9Ny+Yk0MtQKtAPnLrsb1C6YBl4WmampdEPFn yvsGfErYNlmY+mUPjHVyKvQaMY5hH48//RmX0EDWaqsGz+8V7I7wUs1hs oOQQo2zb74lZjeIAuHA4Xkwbz5TGKPPauPSyMeLyaUqSm3E5m7hWXtzUi 3Xj+AC/Of7TGmjYdIX3lrYtQ4GuMEbhWxoyPzdcztwmRfZpEQHId0OqsP w==; X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="asc'?scan'208";a="157251792" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Jun 2023 03:13:27 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 16 Jun 2023 03:13:27 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 16 Jun 2023 03:13:23 -0700 Date: Fri, 16 Jun 2023 11:12:57 +0100 From: Conor Dooley To: Eric Lin CC: , , , , , , , , , , , , , , , , , , , , , Greentime Hu , Zong Li , Nick Hu Subject: Re: [PATCH 2/3] soc: sifive: Add SiFive private L2 cache PMU driver Message-ID: <20230616-revision-speed-a83dc926b334@wendy> References: <20230616063210.19063-1-eric.lin@sifive.com> <20230616063210.19063-3-eric.lin@sifive.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ElvD8fTDzec/LOV5" Content-Disposition: inline In-Reply-To: <20230616063210.19063-3-eric.lin@sifive.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --ElvD8fTDzec/LOV5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 16, 2023 at 02:32:09PM +0800, Eric Lin wrote: > From: Greentime Hu >=20 > This adds SiFive private L2 cache PMU driver. User > can use perf tool to profile by event name and event id. >=20 > Example: > $ perf stat -C 0 -e /sifive_pl2_pmu/inner_acquire_block_btot/ > -e /sifive_pl2_pmu/inner_acquire_block_ntob/ > -e /sifive_pl2_pmu/inner_acquire_block_ntot/ ls >=20 > Performance counter stats for 'CPU(s) 0': >=20 > 300 sifive_pl2_pmu/inner_acquire_block_btot/ > 17801 sifive_pl2_pmu/inner_acquire_block_ntob/ > 5253 sifive_pl2_pmu/inner_acquire_block_ntot/ >=20 > 0.088917326 seconds time elapsed >=20 > $ perf stat -C 0 -e /sifive_pl2_pmu/event=3D0x10001/ > -e /sifive_pl2_pmu/event=3D0x4001/ > -e /sifive_pl2_pmu/event=3D0x8001/ ls >=20 > Performance counter stats for 'CPU(s) 0': >=20 > 251 sifive_pl2_pmu/event=3D0x10001/ > 2620 sifive_pl2_pmu/event=3D0x4001/ > 644 sifive_pl2_pmu/event=3D0x8001/ >=20 > 0.092827110 seconds time elapsed >=20 > Signed-off-by: Greentime Hu > Signed-off-by: Eric Lin > Reviewed-by: Zong Li > Reviewed-by: Nick Hu > --- > drivers/soc/sifive/Kconfig | 9 + > drivers/soc/sifive/Makefile | 1 + > drivers/soc/sifive/sifive_pl2.h | 20 + > drivers/soc/sifive/sifive_pl2_cache.c | 16 + > drivers/soc/sifive/sifive_pl2_pmu.c | 669 ++++++++++++++++++++++++++ Perf drivers should be in drivers/perf, no? Cheers, Conor. --ElvD8fTDzec/LOV5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIw1qQAKCRB4tDGHoIJi 0q20AP0SJ+XMu+AbrLQcuJNmsYqvVW9wc6xBagHa9pzRoEw0mwD+K5s2+gB8wow+ BqnI6l1BRUx8VsrF6VfTnTaE4ZlUJQM= =YDC2 -----END PGP SIGNATURE----- --ElvD8fTDzec/LOV5--