From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F898EB64D7 for ; Fri, 16 Jun 2023 19:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345458AbjFPTFn (ORCPT ); Fri, 16 Jun 2023 15:05:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245744AbjFPTFk (ORCPT ); Fri, 16 Jun 2023 15:05:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC582D48; Fri, 16 Jun 2023 12:05:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 85131616D2; Fri, 16 Jun 2023 19:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FC1BC433C0; Fri, 16 Jun 2023 19:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686942338; bh=ghVGdlSlgofaafooCK0M9AUa/7WBqwttYf70VLC3SL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HEJyNOEJquwzUGrsoTO/vqorphAT2OvNpcKS0K0rNvNx0ZTywBqzVlmoU3yFMd+w5 ehzF4YY9uUgLPDCM0XlYPddoaF/b0G9pyg2cuTsjeCwGejtIBx4U/9RA3Qvyna732i hN9RkTjquF6i+fUhQwENGZUjzzu/iNkgPaWcJW/aWCqiSxA78Ut+5CRs7Wq8bunTqz XkkaBFh6aBSnNreovnLS4YfOHXuTz2VPw4NAb19RGtJ4+97DEQgtcu+VRUKsx0TcXR 8z1oTzi1WxMxikeEApP/Jo96pdk096VrZiHE2T9pQpFN6OD4zJi00mciec7IUuRDuy WlOLfBDhzaEZw== Date: Fri, 16 Jun 2023 20:05:33 +0100 From: Conor Dooley To: Sascha Hauer Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pengutronix.de, Michael Riesch , Robin Murphy , Vincent Legoll , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support Message-ID: <20230616-swimwear-prewar-f9dce761d2ec@spud> References: <20230616062101.601837-1-s.hauer@pengutronix.de> <20230616062101.601837-23-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f5hj02m+E3XzG/0w" Content-Disposition: inline In-Reply-To: <20230616062101.601837-23-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --f5hj02m+E3XzG/0w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > SoCs the rk3588 has four interrupts (one for each channel) instead of > only one, so increase the number of allowed interrupts to four. >=20 > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutr= onix.de It's unclear what the point of this link is. My comment still stands about whether only the new compatible should be permitted to have more than one interrupt. I don't recall a response to that question on the last version. Cheers, Conor. > Signed-off-by: Sascha Hauer > --- >=20 > Notes: > Changes since v4: > - new patch > =20 > Changes since v5: > - drop interrupt-names property > =20 > Changes since v4: > - new patch >=20 > .../devicetree/bindings/devfreq/event/rockchip,dfi.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi= =2Eyaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > index e8b64494ee8bd..50d3fabe958d5 100644 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - rockchip,rk3399-dfi > - rockchip,rk3568-dfi > + - rockchip,rk3588-dfi > =20 > clocks: > maxItems: 1 > @@ -23,7 +24,8 @@ properties: > - const: pclk_ddr_mon > =20 > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > =20 > reg: > maxItems: 1 > --=20 > 2.39.2 >=20 --f5hj02m+E3XzG/0w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIyyfAAKCRB4tDGHoIJi 0q7BAP0dibTpMPe8hiA9YPH24Slmj5/UQ0L0F/cf633sU+PZjwEAq9HgIGb0ByF6 9pta/XL/QX3K9spBxDgiHPSPJNHrVAs= =RHMZ -----END PGP SIGNATURE----- --f5hj02m+E3XzG/0w--