From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F7EEB64D7 for ; Sun, 18 Jun 2023 19:15:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjFRTPv (ORCPT ); Sun, 18 Jun 2023 15:15:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjFRTPu (ORCPT ); Sun, 18 Jun 2023 15:15:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4391B6; Sun, 18 Jun 2023 12:15:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDA2960DCF; Sun, 18 Jun 2023 19:15:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80BE7C433C8; Sun, 18 Jun 2023 19:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687115748; bh=1O2hpd2p0ZnWkUw7q8Y9HtFfDVuFZLuKIBpyIFN1XIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NcqmPzxU6IqT/PhcVtgmGU+sz/k4DnglYnNpsFIOhs0DXQazEgcB48h8C4azKmREa hdDLUjKL/zWuvDxxDx8ktEvgGGji4KEE83M67HCUT1ofj32lVzLjLUdBkWWUBomz/o JAKfMnM60aoyFj0sGYhkwvqRyeorNLK56KKcbXj5yxxjGI7gGMyiP1QeaUL0fryzkl pyej3ndHeOGRYMpyfd8hGirgQWp4IdKvYq83Nze8K9pKAd4osCHxmUKF4bjEVCeX2J VxA48zjWo6cl9JZcI2G4W4/Ob3c7wEBiUpcBkz4Y6ix76DqFhEweDA+zwo8zXcJksA bspkFOg4HRKGg== Date: Sun, 18 Jun 2023 20:15:42 +0100 From: Conor Dooley To: Lucas Tanure Cc: Yixun Lan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Kevin Hilman , Greg Kroah-Hartman , Nick , Artem , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 5/6] tty: serial: meson: Added T7 SOC compatibility Message-ID: <20230618-pavestone-atrophy-017a464a1dbb@spud> References: <20230615182938.18487-1-tanure@linux.com> <20230615182938.18487-6-tanure@linux.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CrX7CiUT711LxfDS" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --CrX7CiUT711LxfDS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 18, 2023 at 06:40:12PM +0100, Lucas Tanure wrote: > On Fri, Jun 16, 2023 at 12:31=E2=80=AFAM Yixun Lan wrot= e: > > > > Hi Lucas: > > > > On 19:29 Thu 15 Jun , Lucas Tanure wrote: > > > Make UART driver compatible with T7 SOC UART. > > > > > > Signed-off-by: Lucas Tanure > > > --- > > > drivers/tty/serial/meson_uart.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/mes= on_uart.c > > > index 2501db5a7aaf..0208f9a6ba7e 100644 > > > --- a/drivers/tty/serial/meson_uart.c > > > +++ b/drivers/tty/serial/meson_uart.c > > > @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_m= atch[] =3D { > > > .compatible =3D "amlogic,meson-s4-uart", > > > .data =3D (void *)&meson_g12a_uart_data, > > > }, > > > + { > > > + .compatible =3D "amlogic,meson-t7-uart", > > > + .data =3D (void *)&meson_g12a_uart_data, > > I think you are trying to follow previous s4 scheme - to introduce a new > > compatible string, while I think it's not necessary or even wrong, this= will just > > make the dt_match_list longer but without obvious benefits.. > > > > as Conor already raised this question in previous dt-binding patch[4/6], > > how about just using 'amlogic,meson-g12a-uart' which is the first compa= tible > > introduced. > > > > if people agree, we could also drop 'amlogic,meson-s4-uart' since it us= e same > > compatible data as gl12a, anyway it should be separated into another pa= tch.. > Yes, I am dropping this patch and using s4 and g12a compatible lines. If you drop the "amlogic,meson-s4-uart" from here it will break backwards compatibility, because the binding permits "amlogic,meson-s4-uart" in isolation. Please do not make that change. When you introduce the new compatible for the t7, it can fall back to the s4 (or g12a), doesn't really matter, but the existing one for the s4 should not be touched. Cheers, Conor. --CrX7CiUT711LxfDS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZI9X3gAKCRB4tDGHoIJi 0qfqAQClhHK7sWjkb2YXNJ8lYDgSgt3RJ0S64L/6Faq3siZA9gD+LFwCuKva6h98 86uGxsdPFwp5DjlE3ksYwSFHxWRUOQk= =YyUX -----END PGP SIGNATURE----- --CrX7CiUT711LxfDS--