From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57166EB64D7 for ; Sun, 18 Jun 2023 17:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229454AbjFRRaN (ORCPT ); Sun, 18 Jun 2023 13:30:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjFRRaM (ORCPT ); Sun, 18 Jun 2023 13:30:12 -0400 Received: from mailrelay6-1.pub.mailoutpod2-cph3.one.com (mailrelay6-1.pub.mailoutpod2-cph3.one.com [46.30.211.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB1EE4C for ; Sun, 18 Jun 2023 10:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=vG7sqVWtMF5VuXJqEO+23Khmg6kDKBBpVF/2bD8xXYI=; b=BvIbBOVm2GyNkHeIoITTHmii1o0VDJJchx9+/wmJGMuwSo/aaTwoeGCx31BVoe2PpoYalgMInmsMT 9skWHS5xA/IpC4oqoCuoUn5ZQF1cNerBWAjeNPAGIim/AmcS0KBYLGjSVBCLGdRlcPfXDQphcP+UMK QmVJWFoYWQzJBMoakyK4b4uLW3hRbB2XNdgJV1XBNj6U9gZxzIUSrCztuJpvVfGcnQeidBuy7oryh2 9ZqFGsuoaJDGyWCU/cHn6oMsEWh5uGK4SuqQESM7lYsoJLLXqTcJ+vFNEvqtjFfd/rylsGbEjXxscS pHA3HPBaePnwfICzoYqclq4DkdmHx3Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=vG7sqVWtMF5VuXJqEO+23Khmg6kDKBBpVF/2bD8xXYI=; b=6dU47njDUKpt0LUz5p1kycpETnpqrJz5uCy66LvPBlYGJlqr52zoHIWQkkXSSU/sDTSHs4AEatljr nL3Nr9+Bw== X-HalOne-ID: 9902f0ff-0dfd-11ee-84b3-6f01c1d0a443 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay6 (Halon) with ESMTPSA id 9902f0ff-0dfd-11ee-84b3-6f01c1d0a443; Sun, 18 Jun 2023 17:28:55 +0000 (UTC) Date: Sun, 18 Jun 2023 19:28:54 +0200 From: Sam Ravnborg To: Miquel Raynal Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, David Airlie , Daniel Vetter , Thierry Reding , dri-devel@lists.freedesktop.org, Thomas Petazzoni , Thomas Weber Subject: Re: [PATCH 2/2] drm/panel: simple: Add support for Mitsubishi AA084XE01 Message-ID: <20230618172854.GA1952539@ravnborg.org> References: <20230616164524.2806421-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616164524.2806421-1-miquel.raynal@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, On Fri, Jun 16, 2023 at 06:45:24PM +0200, Miquel Raynal wrote: > From: Thomas Weber > > Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA > TFT-LCD module for industrial use. > > Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf > Signed-off-by: Thomas Weber > Signed-off-by: Miquel Raynal > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 8a3b685c2fcc..f79c9f9124a0 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2670,6 +2670,30 @@ static const struct panel_desc mitsubishi_aa070mc01 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH, > }; > > +static const struct drm_display_mode mitsubishi_aa084xe01_mode = { > + .clock = 80000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 24, > + .hsync_end = 1024 + 24 + 63, > + .htotal = 1024 + 24 + 63 + 1, > + .vdisplay = 768, > + .vsync_start = 768 + 3, > + .vsync_end = 768 + 3 + 6, > + .vtotal = 768 + 3 + 6 + 1, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc mitsubishi_aa084xe01 = { > + .modes = &mitsubishi_aa084xe01_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 1024, > + .height = 768, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, > +}; The .connector_type must be set. Also consider if .bus_flags needs to be specified. Sam