devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org,
	Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v2 2/6] dt-bindings: display: st7789v: bound the number of Rx data lines
Date: Sun, 18 Jun 2023 19:37:32 +0200	[thread overview]
Message-ID: <20230618193732.04fc1909@xps-13> (raw)
In-Reply-To: <tcxifa7ol3fukfsdw7hh3kl25dhpviu6lasdc6xasz4dvhjedx@mo2vae6smtok>

Hello Maxime,

maxime@cerno.tech wrote on Sun, 18 Jun 2023 16:37:58 +0200:

> Hi,
> 
> On Fri, Jun 16, 2023 at 06:32:51PM +0200, Miquel Raynal wrote:
> > The ST7789V LCD controller supports regular SPI wiring, as well as no Rx
> > data line at all. The operating system needs to know whether it can read
> > registers from the device or not. Let's detail this specific design
> > possibility by bounding the spi-rx-bus-width property.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  .../devicetree/bindings/display/panel/sitronix,st7789v.yaml   | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> > index 0ccf0487fd8e..a25df7e1df88 100644
> > --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> > @@ -29,6 +29,10 @@ properties:
> >    spi-cpha: true
> >    spi-cpol: true
> >  
> > +  spi-rx-bus-width:
> > +    minimum: 0
> > +    maximum: 1
> > +  
> 
> It's not clear to me what the default would be?

This binding references spi-peripheral-props.yaml which sets the
default to 1, I believe it is sane to keep it that way?

Thanks,
Miquèl

  reply	other threads:[~2023-06-18 17:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 16:32 [PATCH v2 0/6] drm/panel: sitronix-st7789v: Support ET028013DMA panel Miquel Raynal
2023-06-16 16:32 ` [PATCH v2 1/6] dt-bindings: display: st7789v: Add the edt,et028013dma panel compatible Miquel Raynal
2023-06-17  8:51   ` Krzysztof Kozlowski
2023-06-18 14:36   ` Maxime Ripard
2023-06-16 16:32 ` [PATCH v2 2/6] dt-bindings: display: st7789v: bound the number of Rx data lines Miquel Raynal
2023-06-17  8:53   ` Krzysztof Kozlowski
2023-06-18 14:37   ` Maxime Ripard
2023-06-18 17:37     ` Miquel Raynal [this message]
2023-06-19  9:39       ` Maxime Ripard
2023-06-19 10:19         ` Miquel Raynal
2023-06-19 12:31           ` Maxime Ripard
2023-06-16 16:32 ` [PATCH v2 3/6] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default Miquel Raynal
2023-06-18 14:38   ` Maxime Ripard
2023-06-16 16:32 ` [PATCH v2 4/6] drm/panel: sitronix-st7789v: Clarify a definition Miquel Raynal
2023-06-18 14:39   ` Maxime Ripard
2023-06-16 16:32 ` [PATCH v2 5/6] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support Miquel Raynal
2023-06-18 14:40   ` Maxime Ripard
2023-06-16 16:32 ` [PATCH v2 6/6] drm/panel: sitronix-st7789v: Check display ID Miquel Raynal
2023-06-18 14:41   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230618193732.04fc1909@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=maxime@cerno.tech \
    --cc=michael.riesch@wolfvision.net \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sre@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).