From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FF7EB64D9 for ; Mon, 19 Jun 2023 06:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbjFSG7Q (ORCPT ); Mon, 19 Jun 2023 02:59:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjFSG7P (ORCPT ); Mon, 19 Jun 2023 02:59:15 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE561AC for ; Sun, 18 Jun 2023 23:59:12 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1687157950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1KdaauZRk96Ps44rUmpp7eWpG6S5yUxJCxmfYf6qgM=; b=ZzcjdfySthabM0zwwHRt1qjl5uHoBJyBFM3a9KGwn4wmcEgpXqz7RoiRfUc3aaoWzPKPLM kYCaHQXaMTFzt+56IoAZJ2CIwyeQ8NnBwsm5nt3fxqMlnfJooKNiSkxa9DF2YQIwizBIkp ElV4CwsedGEeLQtYM4DK22tQ/JeF8g8agIlgjxqIpaEHJ385URefEz09+mk+5sCg5/tiyG KffZMbLAmIy1jrPns2MU3S4Fo61BHOcYDw4lIbRrVlvFnHZF91leRj5UzAAqrS+nK2QIhb 479hBJsQcBD3cpiGAf7ADVY8WyEEzcDO/dphmff7/pRV6rYIXyPgjerlDkwJbw== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id B0FA5E000D; Mon, 19 Jun 2023 06:59:08 +0000 (UTC) Date: Mon, 19 Jun 2023 08:59:07 +0200 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, Chris Packham , Thomas Petazzoni Subject: Re: [PATCH v2 02/17] dt-bindings: mtd: Create a file for raw NAND chip properties Message-ID: <20230619085907.70218553@xps-13> In-Reply-To: References: <20230606175246.190465-1-miquel.raynal@bootlin.com> <20230606175246.190465-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, krzk@kernel.org wrote on Mon, 19 Jun 2023 08:28:28 +0200: > On 06/06/2023 19:52, Miquel Raynal wrote: > > In an effort to constrain as much as we can the existing binding, we > > want to add "unevaluatedProperties: false" in all the NAND chip > > descriptions part of NAND controller bindings. But in order to do that > > properly, we also need to reference a file which contains all the > > "allowed" properties. Right now this file is nand-chip.yaml but in > > practice raw NAND controllers may use additional properties in their > > NAND chip children node. These properties are listed under > > nand-controller.yaml, which makes the "unevaluatedProperties" checks > > fail while the description are valid. We need to move these NAND chip > > related properties into another file, because we do not want to pollute > > nand-chip.yaml which is also referenced by eg. SPI-NAND devices. > >=20 > > Let's create a raw-nand-chip.yaml file to reference all the properties a > > raw NAND chip description can contain. The chain of inheritance becomes: > > nand-controller.yaml <- raw-nand-chip.yaml > > raw-nand-chip.yaml <- nand-chip.yaml > > spi-nand.yaml <- nand-chip.yaml =20 >=20 > ... >=20 > > - The interpretation of these parameters is implementation-defined, so > > - not all implementations must support all possible > > - combinations. However, implementations are encouraged to further > > - specify the value(s) they support. > > - > > properties: > > $nodename: > > pattern: "^nand-controller(@.*)?" > > @@ -51,79 +41,8 @@ properties: > > =20 > > patternProperties: > > "^nand@[a-f0-9]$": > > - $ref: "nand-chip.yaml#" =20 >=20 > You work on some old tree, judging by email addresses you CC and by > this. I would expect here current next, but this is even pre v6.4-rc1! > Working on something older than current master branch doss not make any > sense. This is really based on v6.4-rc1, I think Rob's tooling is applying the patches against -rc1 so I try to keep the robots happy by picking that tag as base. I know you are removing the quotes so I went through my series and dropped them from all the files which now reference raw-nand-chip.yaml, but of course I missed that one, I am sorry, I will drop the quotes here as well. Thanks, Miqu=C3=A8l