From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0660EB64D8 for ; Wed, 21 Jun 2023 16:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbjFUQMd (ORCPT ); Wed, 21 Jun 2023 12:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbjFUQMc (ORCPT ); Wed, 21 Jun 2023 12:12:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8741981; Wed, 21 Jun 2023 09:12:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEE35615D4; Wed, 21 Jun 2023 16:12:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4F9BC433C8; Wed, 21 Jun 2023 16:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687363946; bh=F6AWTtJIxksfHftPRfXL8xSdr4W3uoaros+jmqwGdq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HYwWn4Yej83L0Ozvd2Lkm4OKqpaUV5ILjyBa57r0tigAcNRaod1vQaTBv/5Qu2vdV H2KuOAbcz4v1xfjU0S6nXg+WcMPr5N6pPDsOnWotoM2yTqAqIe7IaXryPbI3S5Keg6 g+OiQGHvh2t07cRjUfgsT14zlyghI6hr3XTAU2wvaT3qXHHXCVrI5tBmWwuw1wCw2R xlJwXqIsBWcO9kvBOZXWFRLFXClJ/S3e/2Qf2fqG5RJZXaJeaCut3vUen9xmzrON4h Fl6uKmH52wx+Sin+NrmApBVm+w1U3GrTVv5D05qCbDIunnd8Bxi+W/OeyYBPCmgbDO 6TtTVB41yCT9Q== Date: Wed, 21 Jun 2023 17:12:20 +0100 From: Conor Dooley To: Sascha Hauer Cc: Mark Rutland , devicetree@vger.kernel.org, Conor Dooley , Heiko Stuebner , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Robin Murphy , linux-kernel@vger.kernel.org, Rob Herring , Sebastian Reichel , linux-rockchip@lists.infradead.org, Kyungmin Park , MyungJoo Ham , Michael Riesch , kernel@pengutronix.de, Vincent Legoll , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support Message-ID: <20230621-poach-amniotic-2eeb858356c8@spud> References: <20230616062101.601837-1-s.hauer@pengutronix.de> <20230616062101.601837-23-s.hauer@pengutronix.de> <20230616-swimwear-prewar-f9dce761d2ec@spud> <20230621074159.GN18491@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qqJ18BUnkd3ehpaa" Content-Disposition: inline In-Reply-To: <20230621074159.GN18491@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --qqJ18BUnkd3ehpaa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2023 at 09:41:59AM +0200, Sascha Hauer wrote: > On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote: > > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike eali= er > > > SoCs the rk3588 has four interrupts (one for each channel) instead of > > > only one, so increase the number of allowed interrupts to four. > > >=20 > > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pen= gutronix.de > >=20 > > It's unclear what the point of this link is. >=20 > The link was added automatically by b4. I re-applied the series from the > last one I sent just to be sure that I base my work for the new series > on the one I sent last time. I didn't remember that b4 adds these links, > I should have disabled that option. Ah, I see. > > My comment still stands about whether only the new compatible should be > > permitted to have more than one interrupt. I don't recall a response to > > that question on the last version. >=20 > My personal take on this is that such additions make the bindings more > readable by machines, but less by humans. That's why I don't have enough > intrinsic motivation to make this change. > Anyway, if you insist then I'll make it for the next round. No, I don't insist. I just wanted to not be ignored. Acked-by: Conor Dooley Cheers, Conor. --qqJ18BUnkd3ehpaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJMhZAAKCRB4tDGHoIJi 0glxAP95A4qpgG0Kx3VK40STEaGwGLEnpx8i+Bqq6PpR06Bp+AD/VUNaT9byFCmy eld/0kBNSGMr59V6XwdGhIG5VMo5ZQk= =FJnF -----END PGP SIGNATURE----- --qqJ18BUnkd3ehpaa--