Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support

Conor Dooley
2023-06-16T19:05:44Z

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote:
> This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier
> SoCs the rk3588 has four interrupts (one for each channel) instead of
> only one, so increase the number of allowed interrupts to four.
>
> Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de

It's unclear what the point of this link is.
My comment still stands about whether only the new compatible should be
permitted to have more than one interrupt. I don't recall a response to
that question on the last version.

Cheers,
Conor.

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>
> Notes:
> Changes since v4:
> - new patch
>
> Changes since v5:
> - drop interrupt-names property
>
> Changes since v4:
> - new patch
>
> .../devicetree/bindings/devfreq/event/rockchip,dfi.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index e8b64494ee8bd..50d3fabe958d5 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - rockchip,rk3399-dfi
> - rockchip,rk3568-dfi
> + - rockchip,rk3588-dfi
>
> clocks:
> maxItems: 1
> @@ -23,7 +24,8 @@ properties:
> - const: pclk_ddr_mon
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 4
>
> reg:
> maxItems: 1
> --
> 2.39.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]