From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E29EB64DC for ; Wed, 21 Jun 2023 15:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233195AbjFUPJP (ORCPT ); Wed, 21 Jun 2023 11:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233201AbjFUPJA (ORCPT ); Wed, 21 Jun 2023 11:09:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FA0A2973; Wed, 21 Jun 2023 08:03:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1C416157E; Wed, 21 Jun 2023 15:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F92C433C0; Wed, 21 Jun 2023 15:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687359787; bh=cj5yhAR91nw7nDMe8iEdIFGq0BXDEvdX0cKkwZiJH5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CQrPLPisoBCXb19q0a1hpjdHYog/qR2Y2LcZ91Gn1a9RBhQIHAVSkQckFcpCrPViu tLCynOMdssyJG819Z0DaQtiNoPz0hbpq+bfCLUQyFZsGGChpgZl4hkvfiejuoLqT74 xAayz9v536UWtIBqzkoL0aPEaFM5qVD9GDINffI893IS5f//+5Eyc9xcyFG0hzcq2W YvBXdAHy+EbBHSau+FQvDfYbJo/U8BWkk0NsXHDw6IKGXFu2CMNxvRpEQr5rNJa4+I MmNVbX823dh3iK5aG+1kHLtf+/ql4fALSN8HIbXEHvr6L+DYV0Iu9QtNApBGQYd1yR z7KYeCwoE/MDA== Date: Wed, 21 Jun 2023 16:03:02 +0100 From: Lee Jones To: Raymond Hackley Cc: linux-kernel@vger.kernel.org, Pavel Machek , Rob Herring , Krzysztof Kozlowski , Luca Weiss , "open list:LED SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Message-ID: <20230621150302.GF10378@google.com> References: <20230602130644.259933-1-raymondhackley@protonmail.com> <20230602131009.260239-1-raymondhackley@protonmail.com> <20230621150141.GE10378@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230621150141.GE10378@google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 21 Jun 2023, Lee Jones wrote: > On Fri, 02 Jun 2023, Raymond Hackley wrote: > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > > camera flash LEDs. > > > > Signed-off-by: Raymond Hackley > > --- > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > index 4d2ffe5fcfc7..37d2a93780ab 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > @@ -20,6 +20,7 @@ properties: > > compatible: > > enum: > > - ocs,ocp8110 > > + - richtek,rt5033-led > > Why is "-led" appended on to this one and not the others? It's unusual for me to have to dump through a bunch of hoops just to read and then subsequently reply to mail. Can you consider removing whatever encryption you have enabled please? -- Lee Jones [李琼斯]