devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Raymond Hackley <raymondhackley@protonmail.com>
To: lee@kernel.org
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	luca@z3ntu.xyz, pavel@ucw.cz, raymondhackley@protonmail.com,
	robh+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
Date: Wed, 21 Jun 2023 17:47:48 +0000	[thread overview]
Message-ID: <20230621174735.1161-1-raymondhackley@protonmail.com> (raw)
In-Reply-To: <20230621150141.GE10378@google.com>

Hi Lee,

On Wednesday, June 21st, 2023 at 3:01 PM, Lee Jones <lee@kernel.org> wrote:


> On Fri, 02 Jun 2023, Raymond Hackley wrote:
> 
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> > 
> > Signed-off-by: Raymond Hackley raymondhackley@protonmail.com
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
> 
> 
> Why is "-led" appended on to this one and not the others?
> 

"richtek,rt5033" has already been taken by a MFD device, and this LED is
a part of rt5033 MFD, so "-led" is appended here.

> > - sgmicro,sgm3140
> > 
> > enable-gpios:
> > --
> > 
> > 2.30.2

I tried to configure protonmail not to send encrypted mails.
Hope that it works for you.

Regards,
Raymond


  parent reply	other threads:[~2023-06-21 17:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230602130644.259933-1-raymondhackley@protonmail.com>
2023-06-02 13:11 ` [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-21 15:01   ` Lee Jones
2023-06-21 15:03     ` Lee Jones
2023-06-21 15:42       ` Conor Dooley
2023-06-21 17:05         ` Lee Jones
2023-06-21 19:17           ` Conor Dooley
2023-06-21 17:47     ` Raymond Hackley [this message]
2023-06-21 17:56     ` [RESEND PATCH " Raymond Hackley
2023-06-21 18:09   ` [PATCH " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621174735.1161-1-raymondhackley@protonmail.com \
    --to=raymondhackley@protonmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).