From: Raymond Hackley <raymondhackley@protonmail.com>
To: lee@kernel.org
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
luca@z3ntu.xyz, pavel@ucw.cz, raymondhackley@protonmail.com,
robh+dt@kernel.org
Subject: Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
Date: Wed, 21 Jun 2023 17:56:13 +0000 [thread overview]
Message-ID: <20230621175600.1209-1-raymondhackley@protonmail.com> (raw)
In-Reply-To: <20230621150141.GE10378@google.com>
Hi Krzysztof,
On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 02/06/2023 15:38, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
>
>
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
>
There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.
Regards,
Raymond
next prev parent reply other threads:[~2023-06-21 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230602130644.259933-1-raymondhackley@protonmail.com>
2023-06-02 13:11 ` [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-21 15:01 ` Lee Jones
2023-06-21 15:03 ` Lee Jones
2023-06-21 15:42 ` Conor Dooley
2023-06-21 17:05 ` Lee Jones
2023-06-21 19:17 ` Conor Dooley
2023-06-21 17:47 ` Raymond Hackley
2023-06-21 17:56 ` Raymond Hackley [this message]
2023-06-21 18:09 ` Lee Jones
2023-06-02 13:36 [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-04 10:43 ` Krzysztof Kozlowski
2023-06-21 17:56 ` Raymond Hackley
2023-06-08 12:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621175600.1209-1-raymondhackley@protonmail.com \
--to=raymondhackley@protonmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).