* Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 15:01 ` Lee Jones
@ 2023-06-21 15:03 ` Lee Jones
2023-06-21 15:42 ` Conor Dooley
2023-06-21 17:47 ` Raymond Hackley
2023-06-21 17:56 ` [RESEND PATCH " Raymond Hackley
2 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2023-06-21 15:03 UTC (permalink / raw)
To: Raymond Hackley
Cc: linux-kernel, Pavel Machek, Rob Herring, Krzysztof Kozlowski,
Luca Weiss, open list:LED SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, 21 Jun 2023, Lee Jones wrote:
> On Fri, 02 Jun 2023, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> >
> > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
>
> Why is "-led" appended on to this one and not the others?
It's unusual for me to have to dump through a bunch of hoops just to
read and then subsequently reply to mail. Can you consider removing
whatever encryption you have enabled please?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 15:03 ` Lee Jones
@ 2023-06-21 15:42 ` Conor Dooley
2023-06-21 17:05 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Conor Dooley @ 2023-06-21 15:42 UTC (permalink / raw)
To: Lee Jones
Cc: Raymond Hackley, linux-kernel, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Luca Weiss, open list:LED SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]
Raymond,
On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> On Wed, 21 Jun 2023, Lee Jones wrote:
>
> > On Fri, 02 Jun 2023, Raymond Hackley wrote:
> >
> > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > > camera flash LEDs.
> > >
> > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > > ---
> > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > > compatible:
> > > enum:
> > > - ocs,ocp8110
> > > + - richtek,rt5033-led
> >
> > Why is "-led" appended on to this one and not the others?
>
> It's unusual for me to have to dump through a bunch of hoops just to
> read and then subsequently reply to mail. Can you consider removing
> whatever encryption you have enabled please?
https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail
I was under the impression that there was no way to disable this
behaviour, but I saw mention somewhere that they managed to patch the
open source version of the protonmail bridge to function. I cannot find
this on lore, because the person's domain was not a proton one and I
completely forget their name as it was several months ago.
I'll reply here if I find it.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 15:42 ` Conor Dooley
@ 2023-06-21 17:05 ` Lee Jones
2023-06-21 19:17 ` Conor Dooley
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2023-06-21 17:05 UTC (permalink / raw)
To: Conor Dooley
Cc: Raymond Hackley, linux-kernel, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Luca Weiss, open list:LED SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, 21 Jun 2023, Conor Dooley wrote:
> Raymond,
>
> On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> > On Wed, 21 Jun 2023, Lee Jones wrote:
> >
> > > On Fri, 02 Jun 2023, Raymond Hackley wrote:
> > >
> > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > > > camera flash LEDs.
> > > >
> > > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > > > ---
> > > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > @@ -20,6 +20,7 @@ properties:
> > > > compatible:
> > > > enum:
> > > > - ocs,ocp8110
> > > > + - richtek,rt5033-led
> > >
> > > Why is "-led" appended on to this one and not the others?
> >
> > It's unusual for me to have to dump through a bunch of hoops just to
> > read and then subsequently reply to mail. Can you consider removing
> > whatever encryption you have enabled please?
>
> https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail
Thanks for the link. This is perfect!
At least I know it's not just me being unreasonable.
> I was under the impression that there was no way to disable this
> behaviour, but I saw mention somewhere that they managed to patch the
> open source version of the protonmail bridge to function. I cannot find
> this on lore, because the person's domain was not a proton one and I
> completely forget their name as it was several months ago.
> I'll reply here if I find it.
Thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 17:05 ` Lee Jones
@ 2023-06-21 19:17 ` Conor Dooley
0 siblings, 0 replies; 13+ messages in thread
From: Conor Dooley @ 2023-06-21 19:17 UTC (permalink / raw)
To: Lee Jones
Cc: Raymond Hackley, linux-kernel, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Luca Weiss, open list:LED SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
dev.mbornand
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Wed, Jun 21, 2023 at 06:05:24PM +0100, Lee Jones wrote:
> On Wed, 21 Jun 2023, Conor Dooley wrote:
> > On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> > > On Wed, 21 Jun 2023, Lee Jones wrote:
> > > > On Fri, 02 Jun 2023, Raymond Hackley wrote:
> > > It's unusual for me to have to dump through a bunch of hoops just to
> > > read and then subsequently reply to mail. Can you consider removing
> > > whatever encryption you have enabled please?
> >
> > https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail
>
> Thanks for the link. This is perfect!
Ye, no worries chief. I got yelled at about it when I started out, so
figured I should at least document it after I noticed others getting
yelled at for the same reason, since it is a bit insidious.
> At least I know it's not just me being unreasonable.
>
> > I was under the impression that there was no way to disable this
> > behaviour, but I saw mention somewhere that they managed to patch the
> > open source version of the protonmail bridge to function. I cannot find
> > this on lore, because the person's domain was not a proton one and I
> > completely forget their name as it was several months ago.
> > I'll reply here if I find it.
It was Marc Bornand. Add to CC.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 15:01 ` Lee Jones
2023-06-21 15:03 ` Lee Jones
@ 2023-06-21 17:47 ` Raymond Hackley
2023-06-21 17:56 ` [RESEND PATCH " Raymond Hackley
2 siblings, 0 replies; 13+ messages in thread
From: Raymond Hackley @ 2023-06-21 17:47 UTC (permalink / raw)
To: lee
Cc: devicetree, krzysztof.kozlowski+dt, linux-kernel, linux-leds,
luca, pavel, raymondhackley, robh+dt
Hi Lee,
On Wednesday, June 21st, 2023 at 3:01 PM, Lee Jones <lee@kernel.org> wrote:
> On Fri, 02 Jun 2023, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> >
> > Signed-off-by: Raymond Hackley raymondhackley@protonmail.com
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
>
>
> Why is "-led" appended on to this one and not the others?
>
"richtek,rt5033" has already been taken by a MFD device, and this LED is
a part of rt5033 MFD, so "-led" is appended here.
> > - sgmicro,sgm3140
> >
> > enable-gpios:
> > --
> >
> > 2.30.2
I tried to configure protonmail not to send encrypted mails.
Hope that it works for you.
Regards,
Raymond
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-21 15:01 ` Lee Jones
2023-06-21 15:03 ` Lee Jones
2023-06-21 17:47 ` Raymond Hackley
@ 2023-06-21 17:56 ` Raymond Hackley
2 siblings, 0 replies; 13+ messages in thread
From: Raymond Hackley @ 2023-06-21 17:56 UTC (permalink / raw)
To: lee
Cc: devicetree, krzysztof.kozlowski+dt, linux-kernel, linux-leds,
luca, pavel, raymondhackley, robh+dt
Hi Krzysztof,
On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 02/06/2023 15:38, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
>
>
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
>
There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.
Regards,
Raymond
^ permalink raw reply [flat|nested] 13+ messages in thread