Re: [PATCH] ASoC: dt-bindings: microchip,sama7g5-pdmc: Simplify "microchip,mic-pos" constraints

Conor Dooley
2023-06-22T19:52:27Z

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Wed, Jun 21, 2023 at 05:10:44PM -0600, Rob Herring wrote:
> "enum" values should be integers or strings, not arrays (though json-schema
> does allow arrays, we do not). In this case, all possible combinations are
> allowed anyways, so there's little point in expressing as an array.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
> .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> index 9b40268537cb..9aa65c975c4e 100644
> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> @@ -56,13 +56,9 @@ properties:
> items:
> items:
> - description: value for DS line
> + enum: [0, 1]
> - description: value for sampling edge
> - anyOf:
> - - enum:
> - - [0, 0]
> - - [0, 1]
> - - [1, 0]
> - - [1, 1]
> + enum: [0, 1]
> minItems: 1
> maxItems: 4
> uniqueItems: true
> --
> 2.40.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]