From: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
To: bryan.odonoghue@linaro.org
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org, linmengbo0689@protonmail.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
nikita@trvn.ru, robh+dt@kernel.org, stephan@gerhold.net,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts
Date: Fri, 23 Jun 2023 10:47:05 +0000 [thread overview]
Message-ID: <20230623104647.5501-1-linmengbo0689@protonmail.com> (raw)
In-Reply-To: <5fbba4e8-a8d9-0e99-e112-31b5781c1648@linaro.org>
Hi Bryan,
On Friday, June 23rd, 2023 at 10:27 AM, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> > +++ b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
> > @@ -0,0 +1,495 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +
> > +/dts-v1/;
> > +
> > +#include "msm8939-pm8916.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +/ {
> > + model = "Samsung Galaxy A7 (2015)";
> > + compatible = "samsung,a7", "qcom,msm8939";
> > + chassis-type = "handset";
>
>
> Will the downstream bootloader accept this dts without
>
> // This is used by the bootloader to find the correct DTB
> qcom,msm-id = <239 0>;
>
> qcom,board-id = <0xEF08FF1 1>;
>
>
> ?
>
> https://github.com/msm8916-mainline/lk2nd/blob/master/dts/msm8916/msm8939-samsung-r01.dts#L10
>
Similar to A3 and A5, and the other msm8916 devices, with lk2nd,
"qcom,msm-id" or "qcom,board-id" are not required in mainline to boot
this dts.
If I understand correctly, lk2nd will attempt to boot an image with any
qcdt appended.
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dts
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dts
Regards,
Lin
next prev parent reply other threads:[~2023-06-23 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 10:01 [PATCH v2 0/2] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Lin, Meng-Bo
2023-06-23 10:02 ` [PATCH v2 1/2] dt-bindings: qcom: Document msm8939,a7 Lin, Meng-Bo
2023-06-23 10:02 ` [PATCH v2 2/2] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Lin, Meng-Bo
2023-06-23 10:27 ` Bryan O'Donoghue
2023-06-23 10:47 ` Lin, Meng-Bo [this message]
2023-06-23 10:52 ` Bryan O'Donoghue
2023-06-25 19:43 ` Stephan Gerhold
2023-06-26 0:05 ` Bryan O'Donoghue
2023-06-26 7:39 ` Stephan Gerhold
2023-07-22 5:17 ` [PATCH v2 0/2] " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623104647.5501-1-linmengbo0689@protonmail.com \
--to=linmengbo0689@protonmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).