From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7B3EB64D7 for ; Fri, 23 Jun 2023 10:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjFWKsy (ORCPT ); Fri, 23 Jun 2023 06:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjFWKsu (ORCPT ); Fri, 23 Jun 2023 06:48:50 -0400 Received: from mail-40137.protonmail.ch (mail-40137.protonmail.ch [185.70.40.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782B1170B for ; Fri, 23 Jun 2023 03:48:49 -0700 (PDT) Date: Fri, 23 Jun 2023 10:47:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1687517327; x=1687776527; bh=njggoM5qv9v0nrUjGAlbTE4gjHY6AHfrf/AEkceyafU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=m+GfRfTg/4EBmzW1ShQVhw62yM1BMw+JUawuWgiRyztr8dBIxT/FD5PH93ZLWn901 A8GNRhftM9lRcmXODGL3hqXHsSYzIu+RciDFsaoKt5nydntanOMoAjn1H1Jc2J+bDy C4kjGx6l6DLexxWU8sNAv4Nv9686ufi4ywT8raSpRCPfEq2VeRtv4nnb08iMNAYpDO 6VZyRGWM30rQ7IZgYJnRWCQRQHkoF3MZFNr1kOq8+BSi7yPG/p5u7FzzqNLDEpfexj bT+6dv+J4ik3KF+9lgHlpVqX5TAUfbVIAjtU6BGa4A85+1Xt6VkLYEg/FM0c/p2+9X P33SrYXhbnkmQ== To: bryan.odonoghue@linaro.org From: "Lin, Meng-Bo" Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org, linmengbo0689@protonmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, nikita@trvn.ru, robh+dt@kernel.org, stephan@gerhold.net, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Message-ID: <20230623104647.5501-1-linmengbo0689@protonmail.com> In-Reply-To: <5fbba4e8-a8d9-0e99-e112-31b5781c1648@linaro.org> References: <20230623100135.5269-1-linmengbo0689@protonmail.com> <20230623100237.5299-1-linmengbo0689@protonmail.com> <5fbba4e8-a8d9-0e99-e112-31b5781c1648@linaro.org> Feedback-ID: 40467236:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bryan, On Friday, June 23rd, 2023 at 10:27 AM, Bryan O'Donoghue wrote: > > +++ b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts > > @@ -0,0 +1,495 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > + > > +/dts-v1/; > > + > > +#include "msm8939-pm8916.dtsi" > > + > > +#include > > +#include > > +#include > > + > > +/ { > > + model =3D "Samsung Galaxy A7 (2015)"; > > + compatible =3D "samsung,a7", "qcom,msm8939"; > > + chassis-type =3D "handset"; >=20 >=20 > Will the downstream bootloader accept this dts without >=20 > // This is used by the bootloader to find the correct DTB > qcom,msm-id =3D <239 0>; >=20 > qcom,board-id =3D <0xEF08FF1 1>; >=20 >=20 > ? >=20 > https://github.com/msm8916-mainline/lk2nd/blob/master/dts/msm8916/msm8939= -samsung-r01.dts#L10 >=20 Similar to A3 and A5, and the other msm8916 devices, with lk2nd, "qcom,msm-id" or "qcom,board-id" are not required in mainline to boot this dts. If I understand correctly, lk2nd will attempt to boot an image with any qcdt appended. https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8= 916-samsung-a3u-eur.dts https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8= 916-samsung-a5u-eur.dts Regards, Lin