[PATCH 0/5] scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings

[PATCH 0/5] scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings

[Abel Vesa]

These are all the warnings left to fix for qcom,ufs schema.

Abel Vesa (5):
  scsi: dt-bindings: ufs: qcom: Fix ICE phandle
  scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125
  scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x
  scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks
  scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding
    reg-names

 .../devicetree/bindings/ufs/qcom,ufs.yaml     | 49 ++++++++++++++++---
 1 file changed, 43 insertions(+), 6 deletions(-)

-- 
2.34.1

[PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle

[Abel Vesa]

The check for 'qcom,ice' property is wrong. Fix it by checking using
if-required clause and expand the clocks minItems and maxItems for
platforms where 'qcom,ice' is not required so that it includes platforms
with single reg entry and clocks that do not provide an ICE one.

Fixes: 29a6d1215b7c ("scsi: ufs: dt-bindings: qcom: Add ICE phandle")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 943dafb69529..bdfa86a0cc98 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -194,9 +194,8 @@ allOf:
     # TODO: define clock bindings for qcom,msm8994-ufshc
 
   - if:
-      properties:
-        qcom,ice:
-          maxItems: 1
+      required:
+        - qcom,ice
     then:
       properties:
         reg:
@@ -207,10 +206,10 @@ allOf:
     else:
       properties:
         reg:
-          minItems: 2
+          minItems: 1
           maxItems: 2
         clocks:
-          minItems: 9
+          minItems: 8
           maxItems: 11
 
 unevaluatedProperties: false
-- 
2.34.1

Re: [PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle

[Krzysztof Kozlowski]

On 23/06/2023 13:30, Abel Vesa wrote:
> The check for 'qcom,ice' property is wrong. Fix it by checking using
> if-required clause and expand the clocks minItems and maxItems for
> platforms where 'qcom,ice' is not required so that it includes platforms
> with single reg entry and clocks that do not provide an ICE one.
> 
> Fixes: 29a6d1215b7c ("scsi: ufs: dt-bindings: qcom: Add ICE phandle")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 9 ++++----


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125

[Abel Vesa]

Add the compatible string for the UFS on sm6115 and sm6125 platforms.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 .../devicetree/bindings/ufs/qcom,ufs.yaml     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index bdfa86a0cc98..46f454ec3688 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -29,6 +29,8 @@ properties:
           - qcom,sa8775p-ufshc
           - qcom,sc8280xp-ufshc
           - qcom,sdm845-ufshc
+          - qcom,sm6115-ufshc
+          - qcom,sm6125-ufshc
           - qcom,sm6350-ufshc
           - qcom,sm8150-ufshc
           - qcom,sm8250-ufshc
@@ -163,6 +165,36 @@ allOf:
           minItems: 2
           maxItems: 2
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sm6115-ufshc
+              - qcom,sm6125-ufshc
+    then:
+      properties:
+        clocks:
+          minItems: 8
+          maxItems: 8
+        clock-names:
+          items:
+            - const: core_clk
+            - const: bus_aggr_clk
+            - const: iface_clk
+            - const: core_clk_unipro
+            - const: ref_clk
+            - const: tx_lane0_sync_clk
+            - const: rx_lane0_sync_clk
+            - const: ice_core_clk
+        reg:
+          minItems: 2
+          maxItems: 2
+        reg-names:
+          items:
+            - const: std
+            - const: ice
+
   - if:
       properties:
         compatible:
-- 
2.34.1

Re: [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125

[Krzysztof Kozlowski]

On 23/06/2023 13:30, Abel Vesa wrote:
> Add the compatible string for the UFS on sm6115 and sm6125 platforms.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  .../devicetree/bindings/ufs/qcom,ufs.yaml     | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index bdfa86a0cc98..46f454ec3688 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -29,6 +29,8 @@ properties:
>            - qcom,sa8775p-ufshc
>            - qcom,sc8280xp-ufshc
>            - qcom,sdm845-ufshc
> +          - qcom,sm6115-ufshc
> +          - qcom,sm6125-ufshc
>            - qcom,sm6350-ufshc
>            - qcom,sm8150-ufshc
>            - qcom,sm8250-ufshc
> @@ -163,6 +165,36 @@ allOf:
>            minItems: 2
>            maxItems: 2
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,sm6115-ufshc
> +              - qcom,sm6125-ufshc
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 8
> +          maxItems: 8
> +        clock-names:
> +          items:
> +            - const: core_clk
> +            - const: bus_aggr_clk
> +            - const: iface_clk
> +            - const: core_clk_unipro
> +            - const: ref_clk
> +            - const: tx_lane0_sync_clk
> +            - const: rx_lane0_sync_clk
> +            - const: ice_core_clk
> +        reg:
> +          minItems: 2
> +          maxItems: 2
> +        reg-names:
> +          items:
> +            - const: std
> +            - const: ice

Same comment about reg-names as for your further patch.

I guess this will supersed the
https://lore.kernel.org/all/20221215190404.398788-1-they@mint.lgbt/
(because it was abandoned... I keep rebasing this patch for half a year)

Best regards,
Krzysztof

Re: [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125

[Krzysztof Kozlowski]

On 23/06/2023 14:33, Krzysztof Kozlowski wrote:
> On 23/06/2023 13:30, Abel Vesa wrote:
>> Add the compatible string for the UFS on sm6115 and sm6125 platforms.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>>  .../devicetree/bindings/ufs/qcom,ufs.yaml     | 32 +++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index bdfa86a0cc98..46f454ec3688 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -29,6 +29,8 @@ properties:
>>            - qcom,sa8775p-ufshc
>>            - qcom,sc8280xp-ufshc
>>            - qcom,sdm845-ufshc
>> +          - qcom,sm6115-ufshc
>> +          - qcom,sm6125-ufshc
>>            - qcom,sm6350-ufshc
>>            - qcom,sm8150-ufshc
>>            - qcom,sm8250-ufshc
>> @@ -163,6 +165,36 @@ allOf:
>>            minItems: 2
>>            maxItems: 2
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - qcom,sm6115-ufshc
>> +              - qcom,sm6125-ufshc
>> +    then:
>> +      properties:
>> +        clocks:
>> +          minItems: 8
>> +          maxItems: 8
>> +        clock-names:
>> +          items:
>> +            - const: core_clk
>> +            - const: bus_aggr_clk
>> +            - const: iface_clk
>> +            - const: core_clk_unipro
>> +            - const: ref_clk
>> +            - const: tx_lane0_sync_clk
>> +            - const: rx_lane0_sync_clk
>> +            - const: ice_core_clk
>> +        reg:
>> +          minItems: 2
>> +          maxItems: 2
>> +        reg-names:
>> +          items:
>> +            - const: std
>> +            - const: ice
> 
> Same comment about reg-names as for your further patch.
> 
> I guess this will supersed the
> https://lore.kernel.org/all/20221215190404.398788-1-they@mint.lgbt/
> (because it was abandoned... I keep rebasing this patch for half a year)
> 

The 6115 is even older - from October:

https://lore.kernel.org/all/20221030094258.486428-2-iskren.chernev@gmail.com/

Let's go with your patch, but you anyway need to fix reg-names.

Best regards,
Krzysztof

[PATCH 3/5] scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x

[Abel Vesa]

Add the compatible string for the UFS on sc8180x platforms.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 46f454ec3688..4dad3f9ba81f 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -27,6 +27,7 @@ properties:
           - qcom,msm8996-ufshc
           - qcom,msm8998-ufshc
           - qcom,sa8775p-ufshc
+          - qcom,sc8180x-ufshc
           - qcom,sc8280xp-ufshc
           - qcom,sdm845-ufshc
           - qcom,sm6115-ufshc
@@ -113,6 +114,7 @@ allOf:
             enum:
               - qcom,msm8998-ufshc
               - qcom,sa8775p-ufshc
+              - qcom,sc8180x-ufshc
               - qcom,sc8280xp-ufshc
               - qcom,sm8250-ufshc
               - qcom,sm8350-ufshc
-- 
2.34.1

Re: [PATCH 3/5] scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x

[Krzysztof Kozlowski]

On 23/06/2023 13:30, Abel Vesa wrote:
> Add the compatible string for the UFS on sc8180x platforms.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

https://lore.kernel.org/r/20230530162454.51708-5-vkoul@kernel.org


Best regards,
Krzysztof

[PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks

[Abel Vesa]

The sm8450 has an ICE clock, so move the compatible to the proper
clocks check.

Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 4dad3f9ba81f..0209713d1f88 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -118,7 +118,6 @@ allOf:
               - qcom,sc8280xp-ufshc
               - qcom,sm8250-ufshc
               - qcom,sm8350-ufshc
-              - qcom,sm8450-ufshc
               - qcom,sm8550-ufshc
     then:
       properties:
@@ -147,6 +146,7 @@ allOf:
               - qcom,sdm845-ufshc
               - qcom,sm6350-ufshc
               - qcom,sm8150-ufshc
+              - qcom,sm8450-ufshc
     then:
       properties:
         clocks:
-- 
2.34.1

Re: [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks

[Rob Herring]

On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote:
> The sm8450 has an ICE clock, so move the compatible to the proper
> clocks check.
> 
> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230623113009.2512206-5-abel.vesa@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks

[Rob Herring]

On Fri, Jun 23, 2023 at 06:21:24AM -0600, Rob Herring wrote:
> 
> On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote:
> > The sm8450 has an ICE clock, so move the compatible to the proper
> > clocks check.
> > 
> > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#

Looks like patch 1 didn't apply for me and would fix this.

Rob

[PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Abel Vesa]

There is a warning on dtbs check for sdm845, amongst other platforms,
about the reg-names being unevaluated. Fix that by adding reg-names to
the clocks and reg properties check for such platforms.

Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 0209713d1f88..894b57117314 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -166,6 +166,10 @@ allOf:
         reg:
           minItems: 2
           maxItems: 2
+        reg-names:
+          items:
+            - const: std
+            - const: ice
 
   - if:
       properties:
-- 
2.34.1

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Krzysztof Kozlowski]

On 23/06/2023 13:30, Abel Vesa wrote:
> There is a warning on dtbs check for sdm845, amongst other platforms,
> about the reg-names being unevaluated. Fix that by adding reg-names to
> the clocks and reg properties check for such platforms.
> 
> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index 0209713d1f88..894b57117314 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -166,6 +166,10 @@ allOf:
>          reg:
>            minItems: 2
>            maxItems: 2
> +        reg-names:
> +          items:
> +            - const: std
> +            - const: ice

reg-names looks like a new property, so it should be defined in
top-level and just constrained per-variant.

Also there was similar approach:
https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/

but I guess no resends and it can be superseded.

Best regards,
Krzysztof

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Luca Weiss]

On Fri Jun 23, 2023 at 2:31 PM CEST, Krzysztof Kozlowski wrote:
> On 23/06/2023 13:30, Abel Vesa wrote:
> > There is a warning on dtbs check for sdm845, amongst other platforms,
> > about the reg-names being unevaluated. Fix that by adding reg-names to
> > the clocks and reg properties check for such platforms.
> > 
> > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > index 0209713d1f88..894b57117314 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > @@ -166,6 +166,10 @@ allOf:
> >          reg:
> >            minItems: 2
> >            maxItems: 2
> > +        reg-names:
> > +          items:
> > +            - const: std
> > +            - const: ice
>
> reg-names looks like a new property, so it should be defined in
> top-level and just constrained per-variant.
>
> Also there was similar approach:
> https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/
>
> but I guess no resends and it can be superseded.

Right, the patches got reviews but was never applied... I really need to
find a strategy to keep track of sent patches until they're applied with
my work mailbox, it's not the first time that a patch has gotten
forgotten.

With my private mailbox I just have a different folder for patches that
have been sent which I archive once they're applied, but with work GMail
I don't see how I can easily replicate this since it's also not grouping
threads properly.

Also patch 4/5 in this series has an equivalent from me:
https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-3-dc7a04699579@fairphone.com/
^ this might also be preferable since I guess it doesn't break
dt_binding_check?

Regards
Luca

>
> Best regards,
> Krzysztof

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Rob Herring]

On Fri, Jun 23, 2023 at 02:38:04PM +0200, Luca Weiss wrote:
> On Fri Jun 23, 2023 at 2:31 PM CEST, Krzysztof Kozlowski wrote:
> > On 23/06/2023 13:30, Abel Vesa wrote:
> > > There is a warning on dtbs check for sdm845, amongst other platforms,
> > > about the reg-names being unevaluated. Fix that by adding reg-names to
> > > the clocks and reg properties check for such platforms.
> > > 
> > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > index 0209713d1f88..894b57117314 100644
> > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > @@ -166,6 +166,10 @@ allOf:
> > >          reg:
> > >            minItems: 2
> > >            maxItems: 2
> > > +        reg-names:
> > > +          items:
> > > +            - const: std
> > > +            - const: ice
> >
> > reg-names looks like a new property, so it should be defined in
> > top-level and just constrained per-variant.
> >
> > Also there was similar approach:
> > https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/
> >
> > but I guess no resends and it can be superseded.
> 
> Right, the patches got reviews but was never applied... I really need to
> find a strategy to keep track of sent patches until they're applied with
> my work mailbox, it's not the first time that a patch has gotten
> forgotten.

There was an error reported on the above series. Why would it be 
applied?

That said, I'm not sure SCSI maintainers consistently apply DT only 
patch series.

> With my private mailbox I just have a different folder for patches that
> have been sent which I archive once they're applied, but with work GMail
> I don't see how I can easily replicate this since it's also not grouping
> threads properly.

Yeah, GMail sucks for that. I use 'lei' to get all my patches and 
replies to them (though its caching will miss replies). Then I delete 
them from the mbox when they are applied or otherwise finished. lei 
updates won't re-add them to the mbox.

Rob

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Krzysztof Kozlowski]

On 23/06/2023 23:17, Rob Herring wrote:
>> With my private mailbox I just have a different folder for patches that
>> have been sent which I archive once they're applied, but with work GMail
>> I don't see how I can easily replicate this since it's also not grouping
>> threads properly.
> 
> Yeah, GMail sucks for that. I use 'lei' to get all my patches and 
> replies to them (though its caching will miss replies). Then I delete 
> them from the mbox when they are applied or otherwise finished. lei 
> updates won't re-add them to the mbox.

That's interesting approach. What's your lei search query for getting
your patches? "f:rob" would get all your threads you participated in.

Best regards,
Krzysztof

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Rob Herring]

On Sat, Jun 24, 2023 at 09:49:12AM +0200, Krzysztof Kozlowski wrote:
> On 23/06/2023 23:17, Rob Herring wrote:
> >> With my private mailbox I just have a different folder for patches that
> >> have been sent which I archive once they're applied, but with work GMail
> >> I don't see how I can easily replicate this since it's also not grouping
> >> threads properly.
> > 
> > Yeah, GMail sucks for that. I use 'lei' to get all my patches and 
> > replies to them (though its caching will miss replies). Then I delete 
> > them from the mbox when they are applied or otherwise finished. lei 
> > updates won't re-add them to the mbox.
> 
> That's interesting approach. What's your lei search query for getting
> your patches? "f:rob" would get all your threads you participated in.

This is what I have:

        q = (dfn:drivers OR dfn:sound OR dfn:tools OR dfn:kernel OR \
         dfn:arch OR dfn:Documentation OR dfn:include OR dfn:scripts) AND \
         f:robh@kernel.org AND rt:3.month.ago..

Really, I'd like a 'is a patch' flag or 'dfn:*' or 'dfn:/' here, but I 
didn't convince the lei maintainer such a thing is needed. Sigh.

Also, you have to disable lei's caching with the --remote-fudge-time 
option because it will miss replies to the matching query. Also reported 
and not fixed...

Rob

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Luca Weiss]

Hi Rob,

On Fri Jun 23, 2023 at 11:17 PM CEST, Rob Herring wrote:
> On Fri, Jun 23, 2023 at 02:38:04PM +0200, Luca Weiss wrote:
> > On Fri Jun 23, 2023 at 2:31 PM CEST, Krzysztof Kozlowski wrote:
> > > On 23/06/2023 13:30, Abel Vesa wrote:
> > > > There is a warning on dtbs check for sdm845, amongst other platforms,
> > > > about the reg-names being unevaluated. Fix that by adding reg-names to
> > > > the clocks and reg properties check for such platforms.
> > > > 
> > > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > > index 0209713d1f88..894b57117314 100644
> > > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > > @@ -166,6 +166,10 @@ allOf:
> > > >          reg:
> > > >            minItems: 2
> > > >            maxItems: 2
> > > > +        reg-names:
> > > > +          items:
> > > > +            - const: std
> > > > +            - const: ice
> > >
> > > reg-names looks like a new property, so it should be defined in
> > > top-level and just constrained per-variant.
> > >
> > > Also there was similar approach:
> > > https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/
> > >
> > > but I guess no resends and it can be superseded.
> > 
> > Right, the patches got reviews but was never applied... I really need to
> > find a strategy to keep track of sent patches until they're applied with
> > my work mailbox, it's not the first time that a patch has gotten
> > forgotten.
>
> There was an error reported on the above series. Why would it be 
> applied?

The error report at [0] complains about reg-names but I'm quite sure
that patch 2/3 resolves this error. Does your bot only apply one patch
at a time and run the check or apply all of them and then run it? It's
been a while but I'm fairly sure I ran all of the checks before sending
since I also documented some other patches in the cover letter there.

[0] https://lore.kernel.org/all/167241769341.1925758.17856681634949446114.robh@kernel.org/

>
> That said, I'm not sure SCSI maintainers consistently apply DT only 
> patch series.
>
> > With my private mailbox I just have a different folder for patches that
> > have been sent which I archive once they're applied, but with work GMail
> > I don't see how I can easily replicate this since it's also not grouping
> > threads properly.
>
> Yeah, GMail sucks for that. I use 'lei' to get all my patches and 
> replies to them (though its caching will miss replies). Then I delete 
> them from the mbox when they are applied or otherwise finished. lei 
> updates won't re-add them to the mbox.

I'll try to figure something out with GMail.. Perhaps just adding a
label "not yet applied" which I manually remove once it's applied would
be sufficient.

Regards
Luca

>
> Rob

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Krzysztof Kozlowski]

On 26/06/2023 08:38, Luca Weiss wrote:
>>>> but I guess no resends and it can be superseded.
>>>
>>> Right, the patches got reviews but was never applied... I really need to
>>> find a strategy to keep track of sent patches until they're applied with
>>> my work mailbox, it's not the first time that a patch has gotten
>>> forgotten.
>>
>> There was an error reported on the above series. Why would it be 
>> applied?
> 
> The error report at [0] complains about reg-names but I'm quite sure
> that patch 2/3 resolves this error. Does your bot only apply one patch
> at a time and run the check or apply all of them and then run it? It's
> been a while but I'm fairly sure I ran all of the checks before sending
> since I also documented some other patches in the cover letter there.

You did it in cover letter, not in the patch, so there is no dependency
for bots recorded.

> 
> [0] https://lore.kernel.org/all/167241769341.1925758.17856681634949446114.robh@kernel.org/

Your patch 2/3 could not be applied to any tree. 3/3 applied but without
previous one caused warnings.




Best regards,
Krzysztof

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Luca Weiss]

On Mon Jun 26, 2023 at 9:41 AM CEST, Krzysztof Kozlowski wrote:
> On 26/06/2023 08:38, Luca Weiss wrote:
> >>>> but I guess no resends and it can be superseded.
> >>>
> >>> Right, the patches got reviews but was never applied... I really need to
> >>> find a strategy to keep track of sent patches until they're applied with
> >>> my work mailbox, it's not the first time that a patch has gotten
> >>> forgotten.
> >>
> >> There was an error reported on the above series. Why would it be 
> >> applied?
> > 
> > The error report at [0] complains about reg-names but I'm quite sure
> > that patch 2/3 resolves this error. Does your bot only apply one patch
> > at a time and run the check or apply all of them and then run it? It's
> > been a while but I'm fairly sure I ran all of the checks before sending
> > since I also documented some other patches in the cover letter there.
>
> You did it in cover letter, not in the patch, so there is no dependency
> for bots recorded.

I'm not aware how to put extra comments into a patch in a series with
b4, at least last time I checked I don't think it was possible? But I
also thought the cover letter was exactly there for giving some
background of the series and documenting any dependencies on other
patches.

>
> > 
> > [0] https://lore.kernel.org/all/167241769341.1925758.17856681634949446114.robh@kernel.org/
>
> Your patch 2/3 could not be applied to any tree. 3/3 applied but without
> previous one caused warnings.

Anyways, just resent the series as v4, maybe this time it can get picked
up... Should have enough reviews by now :)

Regards
Luca

>
>
>
>
> Best regards,
> Krzysztof

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Rob Herring]

On Mon, Jun 26, 2023 at 10:19:09AM +0200, Luca Weiss wrote:
> On Mon Jun 26, 2023 at 9:41 AM CEST, Krzysztof Kozlowski wrote:
> > On 26/06/2023 08:38, Luca Weiss wrote:
> > >>>> but I guess no resends and it can be superseded.
> > >>>
> > >>> Right, the patches got reviews but was never applied... I really need to
> > >>> find a strategy to keep track of sent patches until they're applied with
> > >>> my work mailbox, it's not the first time that a patch has gotten
> > >>> forgotten.
> > >>
> > >> There was an error reported on the above series. Why would it be 
> > >> applied?
> > > 
> > > The error report at [0] complains about reg-names but I'm quite sure
> > > that patch 2/3 resolves this error. Does your bot only apply one patch
> > > at a time and run the check or apply all of them and then run it? It's
> > > been a while but I'm fairly sure I ran all of the checks before sending
> > > since I also documented some other patches in the cover letter there.
> >
> > You did it in cover letter, not in the patch, so there is no dependency
> > for bots recorded.
> 
> I'm not aware how to put extra comments into a patch in a series with
> b4, at least last time I checked I don't think it was possible? But I
> also thought the cover letter was exactly there for giving some
> background of the series and documenting any dependencies on other
> patches.

I just put a '---' line and comments after that in the commit messages. 
That works fine unless your git branch is going upstream directly (i.e. 
via a pull request). Even when I apply my own patches, I get them from 
lore and apply so the comments are dropped.

Rob

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[Luca Weiss]

On Tue Jun 27, 2023 at 5:18 PM CEST, Rob Herring wrote:
> On Mon, Jun 26, 2023 at 10:19:09AM +0200, Luca Weiss wrote:
> > On Mon Jun 26, 2023 at 9:41 AM CEST, Krzysztof Kozlowski wrote:
> > > On 26/06/2023 08:38, Luca Weiss wrote:
> > > >>>> but I guess no resends and it can be superseded.
> > > >>>
> > > >>> Right, the patches got reviews but was never applied... I really need to
> > > >>> find a strategy to keep track of sent patches until they're applied with
> > > >>> my work mailbox, it's not the first time that a patch has gotten
> > > >>> forgotten.
> > > >>
> > > >> There was an error reported on the above series. Why would it be 
> > > >> applied?
> > > > 
> > > > The error report at [0] complains about reg-names but I'm quite sure
> > > > that patch 2/3 resolves this error. Does your bot only apply one patch
> > > > at a time and run the check or apply all of them and then run it? It's
> > > > been a while but I'm fairly sure I ran all of the checks before sending
> > > > since I also documented some other patches in the cover letter there.
> > >
> > > You did it in cover letter, not in the patch, so there is no dependency
> > > for bots recorded.
> > 
> > I'm not aware how to put extra comments into a patch in a series with
> > b4, at least last time I checked I don't think it was possible? But I
> > also thought the cover letter was exactly there for giving some
> > background of the series and documenting any dependencies on other
> > patches.
>
> I just put a '---' line and comments after that in the commit messages. 
> That works fine unless your git branch is going upstream directly (i.e. 
> via a pull request). Even when I apply my own patches, I get them from 
> lore and apply so the comments are dropped.

Ah, didn't know this was possible/supported. In the past with git
send-email directly I'd edit the patch file and add some text under the
"---" manually but wasn't aware you can put it directly in the commit
message. But I guess if it produces the same output either way it makes
sense.

I won't have a problem with pull requests since I'm just a normal patch
submitter ;)

Thanks for the advice!

Regards
Luca

>
> Rob

Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

[James Bottomley]

On Fri, 2023-06-23 at 14:38 +0200, Luca Weiss wrote:
> With my private mailbox I just have a different folder for patches
> that have been sent which I archive once they're applied, but with
> work GMail I don't see how I can easily replicate this since it's
> also not grouping threads properly.

I have something similar, but instead of multiple folders, I use imap
labels to achieve the same thing (and then evolution search folders to
sort out the labels).  I believe GMail has some primitive labelling
system that actually works (unlike exchange), so you might be able to
get a scheme like that to work.

For my mobile phone, which doesn't have the sophisticated search
folders evolution does, I use dovecot virtual folders to achieve the
same effect.  I'm afraid I don't think GMail has any equivalent of
this.

James