devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
	Manivannan Sadhasivam <mani@kernel.org>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks
Date: Fri, 23 Jun 2023 14:12:30 -0600	[thread overview]
Message-ID: <20230623201230.GA1022063-robh@kernel.org> (raw)
In-Reply-To: <168752288418.27031.1090471926569361855.robh@kernel.org>

On Fri, Jun 23, 2023 at 06:21:24AM -0600, Rob Herring wrote:
> 
> On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote:
> > The sm8450 has an ICE clock, so move the compatible to the proper
> > clocks check.
> > 
> > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
> 	from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#

Looks like patch 1 didn't apply for me and would fix this.

Rob

  reply	other threads:[~2023-06-23 20:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 11:30 [PATCH 0/5] scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings Abel Vesa
2023-06-23 11:30 ` [PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle Abel Vesa
2023-06-23 16:45   ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125 Abel Vesa
2023-06-23 12:33   ` Krzysztof Kozlowski
2023-06-23 12:34     ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 3/5] scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x Abel Vesa
2023-06-23 12:30   ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks Abel Vesa
2023-06-23 12:21   ` Rob Herring
2023-06-23 20:12     ` Rob Herring [this message]
2023-06-23 11:30 ` [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names Abel Vesa
2023-06-23 12:31   ` Krzysztof Kozlowski
2023-06-23 12:38     ` Luca Weiss
2023-06-23 21:17       ` Rob Herring
2023-06-24  7:49         ` Krzysztof Kozlowski
2023-06-27 15:14           ` Rob Herring
2023-06-26  6:38         ` Luca Weiss
2023-06-26  7:41           ` Krzysztof Kozlowski
2023-06-26  8:19             ` Luca Weiss
2023-06-27 15:18               ` Rob Herring
2023-06-28  6:49                 ` Luca Weiss
2023-06-24 12:30       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623201230.GA1022063-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).