From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F8DEB64D7 for ; Mon, 26 Jun 2023 16:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbjFZQFp (ORCPT ); Mon, 26 Jun 2023 12:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbjFZQFo (ORCPT ); Mon, 26 Jun 2023 12:05:44 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C3601A4 for ; Mon, 26 Jun 2023 09:05:43 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-988a076a7d3so521014966b.3 for ; Mon, 26 Jun 2023 09:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1687795542; x=1690387542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UeZ2gJ78a8GPVtCoXPkcAEj2A8pLXaEVQFdsULkrHhc=; b=jEWUUYrwq+I7qYap8fYbNnhmWuPRYIfZ90Rtqjw5+TT0j7h3+O+JlSrwo/JgaKqr4W p3Qc0lIur63SOy/9nVNGESmL8qMzDlfUfeRolhh3ZGgGofF39npPWZTXx/NLSjlFylXy OwcxhP2X1HmNyo1lGb9c7ba+as0ILVT3aLJr8kz5yGpQvybGcz0M4nZvMO5dSYvVShlp mJpEdNjO8YT3HiHGyScAYstiNItI56E8LEZzhXG9xGuEVa54plRs8mq3CLgHfH4fdsyG c3fQpSRDFKCZXUbc2gpQ2bDn6Oa10jBsu1RnUce4zLCCXVu1uwtApMJxK5/El3tzIZUS 0mtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687795542; x=1690387542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UeZ2gJ78a8GPVtCoXPkcAEj2A8pLXaEVQFdsULkrHhc=; b=SwUMIsiUH4NkBZkMykvkR1YLgvWoBs7jKPSP+P6CCaPFNKBO6Bg6itGWSObdNrNEYp Xknrv8doOrGz1LbG4G89LwAT9FKH9EMqfNoJmwH54ADLTbejD3bz1Tm63btr85NxgGoz gfHMj+MuUu4E1eMx6EI94S0VeYr8shceobYK/SXTee6ioEp+kzRpe6sfJGvH4WDgQrg7 w+7VvW4n3GRo2MBaDlAkC0J48I2Y6DF0+D6UmomzZo/72IP4gyTWXzqsnyDUc7Rpgece QWgOsKqMuxRSma5gizVUPSjI8jikMu13fWC4jzizLS2KnKKECXfjvib8Kzn086vnSb7T a23Q== X-Gm-Message-State: AC+VfDzJqte6ZVq2UMKZW7PhRLA8mLsPlRpnN9EMLU+nM47WZuNLfhMi W6KUAwIxyaBMzr0qjKgASj+17g== X-Google-Smtp-Source: ACHHUZ6SnSRadXIWV7VvaW8UyxWKn2ImofeQoznE415eOPemw6zL9MGMc9FMnlWeraLZOM63YoxFyA== X-Received: by 2002:a17:907:983:b0:94e:2db:533e with SMTP id bf3-20020a170907098300b0094e02db533emr28662335ejc.49.1687795542064; Mon, 26 Jun 2023 09:05:42 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id b21-20020a170906491500b009828dac8425sm3421335ejq.105.2023.06.26.09.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 09:05:41 -0700 (PDT) Date: Mon, 26 Jun 2023 18:05:40 +0200 From: Andrew Jones To: Conor Dooley Cc: Conor Dooley , palmer@dabbelt.com, Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Heiko Stuebner , Evan Green , Sunil V L , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/9] RISC-V: don't parse dt/acpi isa string to get rv32/rv64 Message-ID: <20230626-4fb963235f3ab08383a6d9ab@orel> References: <20230626-provable-angrily-81760e8c3cc6@wendy> <20230626-silk-colonize-824390303994@wendy> <20230626-e3ea7beb39c584bfbf7ee836@orel> <20230626-dragonish-romp-9acf4846ae01@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626-dragonish-romp-9acf4846ae01@spud> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jun 26, 2023 at 04:51:29PM +0100, Conor Dooley wrote: > On Mon, Jun 26, 2023 at 05:14:15PM +0200, Andrew Jones wrote: > > On Mon, Jun 26, 2023 at 12:19:39PM +0100, Conor Dooley wrote: > > > From: Heiko Stuebner > > > @@ -333,8 +335,6 @@ static int c_show(struct seq_file *m, void *v) > > > > > > of_node_put(node); > > > } else { > > > - if (!acpi_get_riscv_isa(NULL, cpu_id, &isa)) > > > - print_isa(m, isa); > > > > > > > Extra blank line here to remove. Actually the whole 'else' can be removed > > because the print_mmu() call can be brought up above the > > 'if (acpi_disabled)' > > Can it be? I intentionally did not make that change - wasn't sure > whether re-ordering the fields in there was permissible. I agree we shouldn't change the order, but moving print_mmu() up won't, afaict. > > One of the few things I know does parsing of /proc/cpuinfo is: > https://github.com/google/cpu_features/blob/main/src/impl_riscv_linux.c > and that doesn't seem to care about the mmu, but does rely on > vendor/uarch ordering. > > Makes me wonder, does ACPI break things by leaving out uarch/vendor > fields, if there is something that expects them to exist? We should > not intentionally break stuff in /proc/cpuinfo, but can't say I feel any > sympathy for naively parsing it. Yes, it would be nice for ACPI to be consistent. I'm not sure what can be done about that. Thanks, drew > > > > print_mmu(m); >