From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC00EB64DC for ; Mon, 26 Jun 2023 17:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbjFZRzJ (ORCPT ); Mon, 26 Jun 2023 13:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbjFZRy6 (ORCPT ); Mon, 26 Jun 2023 13:54:58 -0400 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 839F6173A; Mon, 26 Jun 2023 10:54:47 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3457cba78f3so14996895ab.3; Mon, 26 Jun 2023 10:54:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687802087; x=1690394087; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KSyc+a73j8m7K0KIeaQ8LsysU/zcItL6sttRvkyrMs0=; b=ZC6KBDFDHy1QZWie8h0zIupyg8Gp0dAVUy0kAa8GHyFBenat5vjK3B8WgzXWYuoBB8 3Fkq6rfE8Jz8dAy8pXukfNhmWfNFpVXQloWEeYlfsTKLotCXdl/h+m4pRUipBvVOUthi kjKw3g2Zso+uMZyyGAJSfXvgxreX/Nw03nBEk4eWEGUHyd/1lPU1s9kaQW4xjy68ximI urVTt53+Y4ixVOB9MAbaKk1XOD5CCWwY/tbsI4mNaQite7KFtWR9SgtNkQ3elcrTRWeo zKLENzDqf9hY1OJgKySl1qTTHnUFHmAKoXkPi1e1fNMYqOYWuRJOfZkzkloGFyafY9/C O1AA== X-Gm-Message-State: AC+VfDxULjaBRs6+VgMiLHROkZ4/4/byLtwibRq18L37/yvRcGmKMdne qEEnwrb3zKHviGDkho9+0g== X-Google-Smtp-Source: ACHHUZ7MkE7zJamNHOTyZHvfsoPXdRWHmol8FfHFGI+5hV9U+RZMqHt3x9FryQJytL8Xc8IwSyMcVQ== X-Received: by 2002:a92:d30e:0:b0:340:72d1:69a with SMTP id x14-20020a92d30e000000b0034072d1069amr31489125ila.28.1687802086721; Mon, 26 Jun 2023 10:54:46 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id w4-20020a029684000000b0041ac54cbc60sm1880991jai.56.2023.06.26.10.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 10:54:45 -0700 (PDT) Received: (nullmailer pid 3455212 invoked by uid 1000); Mon, 26 Jun 2023 17:54:43 -0000 Date: Mon, 26 Jun 2023 11:54:43 -0600 From: Rob Herring To: Lee Jones Cc: "Sahin, Okan" , Mark Brown , Krzysztof Kozlowski , Liam Girdwood , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Cosmin Tanislav , Stephen Boyd , Ulf Hansson , Caleb Connolly , Marcus Folkesson , "Bolboaca, Ramona" , ChiYuan Huang , "Tilki, Ibrahim" , William Breathitt Gray , Arnd Bergmann , Hugo Villeneuve , ChiaEn Wu , Haibo Chen , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH v7 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Message-ID: <20230626175443.GA3446604-robh@kernel.org> References: <20230412111256.40013-1-okan.sahin@analog.com> <20230412111256.40013-6-okan.sahin@analog.com> <20230420103438.GI9904@google.com> <09eb8e4c-3e73-41f0-bf42-8ddf3c4254ec@sirena.org.uk> <20230421073938.GO996918@google.com> <82612171-46d7-4d82-a8fc-c7d6a99d57e9@sirena.org.uk> <20230621171315.GL10378@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621171315.GL10378@google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 21, 2023 at 06:13:15PM +0100, Lee Jones wrote: > On Tue, 13 Jun 2023, Sahin, Okan wrote: > > > >On Fri, Apr 21, 2023 at 08:39:38AM +0100, Lee Jones wrote: > > > > > >> I'll try anything once! > > > > > >> Fair warning, I think this is going to massively complicate things. > > > > > >> Either we're going to be left with a situation where child-driver > > >> maintainers are scrabbling around looking for previous versions for the > > >> MFD pull-request or contributors being forced to wait a full cycle for > > >> their dependencies to arrive in the maintainer's base. > > > > > >If people are resending after the MFD has gone in they really ought to > > >be including the pull request in the cover letter, with some combination > > >of either referencing the mail or just saying "this depends on the > > >signed tag at url+tag", the same way they would for any other dependency. > > > > > >I can't see how you applying stuff when you can slow things down TBH, > > >the MFD bits will be applied faster and either people can pull in a > > >shared tag or you can apply more commits on top of the existing core > > >driver. > > > > > >> I'm not sure why simply providing your Ack when you're happy with the > > >> driver and forgetting about the set until the pull-request arrives, like > > >> we've been doing for nearly a decade now, isn't working for you anymore > > >> but I'm mostly sure this method will be a regression. > > > > > >Like I said I've not been doing that, I've mostly been just applying the > > >driver when it's ready. This might not have been so visible to you > > >since it means that the regulator driver doesn't appear in the series by > > >the time the MFD settles down. The whole "Acked-for-MFD" has always > > >been a bit confusing TBH, it's not a normal ack ("go ahead and apply > > >this, I'm fine with it") so it was never clear what the intention was. > > > > > >Before I started just applying the drivers there used to be constant > > >problems with things like tags going missing (which some of the time is > > >the submitter just not carrying them but can also be the result of some > > >churn causing them to be deliberately dropped due to changes) or > > >forgetting the series as you suggest and then not looking at some other > > >very similarly named series that was also getting lots of versions after > > >thinking it was one that had been reviewed already. It was all very > > >frustrating. Not doing the tags until the dependencies have settled > > >down means that if it's in my inbox it at least consistently needs some > > >kind of attention and that the submitter didn't drop tags or anything so > > >I know why there's no tag on it even though the version number is high, > > >though it's not ideal either. > > > > Hi Mark and Lee, > > > > Is there anything that I need to do for this patch set. I have received reviewed > > by tag for all of them so far. > > Since we are so late in the day, I'm going to just apply this for v6.5. > > The remainder can then be applied, friction free, for v6.6. Now we have undocmented bindings in use by the driver (as pointed out by 'make dt_compatible_check'). The whole series has all the acks/reviews needed for you to apply the whole thing, so why not take the whole thing? Plus this series has been sitting for 2 months. Not a great experience for submitters... Rob