From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79738EB64D9 for ; Tue, 27 Jun 2023 13:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbjF0NYW (ORCPT ); Tue, 27 Jun 2023 09:24:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjF0NYQ (ORCPT ); Tue, 27 Jun 2023 09:24:16 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 499F9294B for ; Tue, 27 Jun 2023 06:24:14 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-668709767b1so2803141b3a.2 for ; Tue, 27 Jun 2023 06:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687872254; x=1690464254; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Y02hN0PNekjOd5szuk9Ub9WcGYvupKGth45H8Ct66UY=; b=IRjeNnOm4E4Z+pIzRr/Di7z/oSbw5+dbir8tihAqnEil/TvIC7fsGDSw2X/YZLPFqo GAZ+hSGoAgUCgnlB3sS5kstebfnK/iSKbUWe2XyxZuYTHbo+mBws+m+EM2MlmTIY54/R vgXH2d7Nu6b49+mRnvDN6OPuRyLuPsjHHzLlcDAJuM5yGJ7ud/XMPItYri16GetafB8j z6lY4T9sCyHz1GrTJnHsHqMSXi3hHEKLK9nIsJp2cma02Te9I21k24fotjDqzmJ2MdaV Qxbr2ZI36ctG3umjd/xKHbol5V7lZMXcKOJE/jiU7a5GG5cLdY2tzR4F9TOeISJiM7tA T7vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687872254; x=1690464254; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y02hN0PNekjOd5szuk9Ub9WcGYvupKGth45H8Ct66UY=; b=lxDNbNoSQStX66UCTAerrDkQKqpyTewmJCnJoQy1dzDf/3Mh6juysj+ITzgMYy3UaN VpmRfbj+pnwj8lWcX5xXF3TgvrauK2Feze06TyW1/crCznn2FmqfHQw3AZ6gg8nEvUXn N8Mf8JKLgTX+sS9Mps10DgcjRnsIKnn+olttGp4gnGvzWQde2+o6XPPrm7APByEWHBT4 kmU5V4/1QEe6a+2ElLUnrBswZUszhyteVOP2bZgby617+RruAQR4EXPfZg/brBxz6q5S oBLSFjCt+O9F9lznMr0oDEt7GXqWqnrllbPfwAtPs+YXK6D2nNm41FyNj9tpKAZhNjyj MbFQ== X-Gm-Message-State: AC+VfDz051rQndXLQ6DIQgAqoLi86QrQY8BCdQ75K5lxPYEu5F2h5JUK HlL0m5/fuFXN4/vB+AE4TNmc X-Google-Smtp-Source: ACHHUZ7Aa5yD/wVIoF86iX7X1j+YPhnUIsDI1+AG6UNtVTQSxUdTQ0x7XC0A3hZK+P5lJoGx4wIP4w== X-Received: by 2002:a05:6a00:398f:b0:64f:aea5:7b49 with SMTP id fi15-20020a056a00398f00b0064faea57b49mr30320035pfb.17.1687872253752; Tue, 27 Jun 2023 06:24:13 -0700 (PDT) Received: from thinkpad ([117.217.176.90]) by smtp.gmail.com with ESMTPSA id u23-20020a62ed17000000b00668821499c3sm5416179pfh.156.2023.06.27.06.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 06:24:13 -0700 (PDT) Date: Tue, 27 Jun 2023 18:54:06 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Patrick Wildt Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: add explicit rtc interrupt parent Message-ID: <20230627132406.GA5490@thinkpad> References: <20230627085306.6033-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230627085306.6033-1-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 27, 2023 at 10:53:06AM +0200, Johan Hovold wrote: > Unless explicitly specified the interrupt-parent property is inherited > from the parent node on Linux even though this may not be in full > compliance with the devicetree specification. > > Following commit 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: > Specify interrupt parent explicitly"), add an explicit interrupt parent > also for the PMIC RTC node for the benefit of other operating systems > which may be confused by this omission. > > Note that any such OS must still implement a fallback to the root > interrupt domain as most devicetrees are written under the assumption > that the interrupt parent is inherited. > > Reported-by: Patrick Wildt > Signed-off-by: Johan Hovold It is good to encode this in the binding and fix other such instances. Acked-by: Manivannan Sadhasivam - Mani > --- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index a0ba535bb6c9..80ee12ded4f4 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -101,7 +101,7 @@ pmk8280_rtc: rtc@6100 { > compatible = "qcom,pmk8350-rtc"; > reg = <0x6100>, <0x6200>; > reg-names = "rtc", "alarm"; > - interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; > + interrupts-extended = <&spmi_bus 0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; > wakeup-source; > status = "disabled"; > }; > -- > 2.39.3 > -- மணிவண்ணன் சதாசிவம்