[PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Sergio Paracuellos]

Add YAML doc for the system tick counter which is present on Ralink SoCs.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml

diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
new file mode 100644
index 000000000000..59d97feddf4e
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: System tick counter present in Ralink family SoCs
+
+maintainers:
+  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
+
+properties:
+  compatible:
+    const: ralink,cevt-systick
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    systick@d00 {
+        compatible = "ralink,cevt-systick";
+        reg = <0xd00 0x10>;
+
+        interrupt-parent = <&cpuintc>;
+        interrupts = <7>;
+    };
+...
-- 
2.25.1

Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Rob Herring]

On Wed, 28 Jun 2023 10:27:16 +0200, Sergio Paracuellos wrote:
> Add YAML doc for the system tick counter which is present on Ralink SoCs.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: /example-0/cci@ac4a000/i2c-bus@1/camera@60: failed to match any schema with compatible: ['ovti,ov7251']
Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb: /example-0/ethernet@1a000000/mdio/switch@10: failed to match any schema with compatible: ['qca,ar9331-switch']
Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/switch@0: failed to match any schema with compatible: ['marvell,mv88e6190']
Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example.dtb: /example-0/memory-controller@13410000/ethernet@6: failed to match any schema with compatible: ['davicom,dm9000']
Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb: /example-0/iomcu@ffd7e000: failed to match any schema with compatible: ['hisilicon,hi3660-iomcu', 'syscon']
Documentation/devicetree/bindings/leds/common.example.dtb: /example-2/i2c/led-controller@30: failed to match any schema with compatible: ['panasonic,an30259a']
Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma']
Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: /example-0/parent/i2c/camera@36: failed to match any schema with compatible: ['ovti,ov5695']
Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb: /example-1/syscon@20e00000: failed to match any schema with compatible: ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb: /example-2/serial@1e700010: failed to match any schema with compatible: ['socionext,milbeaut-usio-uart']
Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-perictrl.example.dtb: /example-0/peripheral-controller@8a20000/phy@850: failed to match any schema with compatible: ['hisilicon,hi3798cv200-combphy']
Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dtb: /example-0/cpuctrl@a22000/clock@0: failed to match any schema with compatible: ['hisilicon,hix5hd2-clock']
Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dtb: /example-0/system-controller@802000/clock@0: failed to match any schema with compatible: ['hisilicon,hi3620-clock']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/cpu: failed to match any schema with compatible: ['cpu-driver']
Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/codec: failed to match any schema with compatible: ['codec-driver']
Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb: /example-0/pmic@0: failed to match any schema with compatible: ['sprd,sc2731']
Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397']
Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: /example-0/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6q-anatop', 'syscon', 'simple-mfd']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230628082716.2075736-1-sergio.paracuellos@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Rob Herring]

On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> Add YAML doc for the system tick counter which is present on Ralink SoCs.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> new file mode 100644
> index 000000000000..59d97feddf4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: System tick counter present in Ralink family SoCs
> +
> +maintainers:
> +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> +
> +properties:
> +  compatible:
> +    const: ralink,cevt-systick

What is "cevt"? Would be nice to define. Really this should have been 
SoC specific, but it looks like it has been upstream "forever", so fine.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

(the error report can be ignored)

Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Sergio Paracuellos]

Hi Rob,

On Wed, Jun 28, 2023 at 5:40 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> > Add YAML doc for the system tick counter which is present on Ralink SoCs.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> >  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > new file mode 100644
> > index 000000000000..59d97feddf4e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: System tick counter present in Ralink family SoCs
> > +
> > +maintainers:
> > +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: ralink,cevt-systick
>
> What is "cevt"? Would be nice to define. Really this should have been
> SoC specific, but it looks like it has been upstream "forever", so fine.

Not sure what cevt really means, I guess maybe "clock event"? Inside
the documentation this is just listed as "System Tick Counter". It is
upstreamed since Ralink SoCs are on tree. I am just documenting
already mainlined stuff since there are lots of missing  binding docs
for old Ralink SoCs.

>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks!

Best regards,
    Sergio Paracuellos
>
> (the error report can be ignored)

Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Sergio Paracuellos]

On Wed, Jun 28, 2023 at 6:42 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
>
> Hi Rob,
>
> On Wed, Jun 28, 2023 at 5:40 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> > > Add YAML doc for the system tick counter which is present on Ralink SoCs.
> > >
> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > ---
> > >  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
> > >  1 file changed, 38 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > > new file mode 100644
> > > index 000000000000..59d97feddf4e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > > @@ -0,0 +1,38 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: System tick counter present in Ralink family SoCs
> > > +
> > > +maintainers:
> > > +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ralink,cevt-systick
> >
> > What is "cevt"? Would be nice to define. Really this should have been
> > SoC specific, but it looks like it has been upstream "forever", so fine.
>
> Not sure what cevt really means, I guess maybe "clock event"? Inside
> the documentation this is just listed as "System Tick Counter". It is
> upstreamed since Ralink SoCs are on tree. I am just documenting
> already mainlined stuff since there are lots of missing  binding docs
> for old Ralink SoCs.
>
> >
> > Otherwise,
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>

Daniel, is this patch going through your tree?

Thanks,
    Sergio Paracuellos

>
> Thanks!
>
> Best regards,
>     Sergio Paracuellos
> >
> > (the error report can be ignored)

Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

[Sergio Paracuellos]

On Wed, Aug 30, 2023 at 8:54 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
>
> On Wed, Jun 28, 2023 at 6:42 PM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
> >
> > Hi Rob,
> >
> > On Wed, Jun 28, 2023 at 5:40 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> > > > Add YAML doc for the system tick counter which is present on Ralink SoCs.
> > > >
> > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > > ---
> > > >  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
> > > >  1 file changed, 38 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > > > new file mode 100644
> > > > index 000000000000..59d97feddf4e
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > > > @@ -0,0 +1,38 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: System tick counter present in Ralink family SoCs
> > > > +
> > > > +maintainers:
> > > > +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: ralink,cevt-systick
> > >
> > > What is "cevt"? Would be nice to define. Really this should have been
> > > SoC specific, but it looks like it has been upstream "forever", so fine.
> >
> > Not sure what cevt really means, I guess maybe "clock event"? Inside
> > the documentation this is just listed as "System Tick Counter". It is
> > upstreamed since Ralink SoCs are on tree. I am just documenting
> > already mainlined stuff since there are lots of missing  binding docs
> > for old Ralink SoCs.
> >
> > >
> > > Otherwise,
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Daniel, is this patch going through your tree?
>
> Thanks,
>     Sergio Paracuellos

Gentle ping on this patch. I guess nothing missing is here and this
patch can just be added with Rob's RB?

Best regards,
    Sergio Paracuellos
>
> >
> > Thanks!
> >
> > Best regards,
> >     Sergio Paracuellos
> > >
> > > (the error report can be ignored)