From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAC3EB64D9 for ; Thu, 29 Jun 2023 15:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232593AbjF2PXy (ORCPT ); Thu, 29 Jun 2023 11:23:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbjF2PXl (ORCPT ); Thu, 29 Jun 2023 11:23:41 -0400 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85C743588; Thu, 29 Jun 2023 08:23:40 -0700 (PDT) Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7836272f36eso33544139f.1; Thu, 29 Jun 2023 08:23:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688052220; x=1690644220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pIbzwk+16IGxV6FWzckLUrfZmaj1Jf5Ee41P3nY/4zc=; b=Ys/VRdMC92+BFY+CXthvb7nH7z+pnxbZRmSyYJrC6SVWyjWqyZpAdBACMc+6d5IA5z 73oy1WaenNYgzLHLz7ZkHPfhiCBneXGm8IAFOEFWNiYXRU2dz885X1MkYog35KnE5yuA 8IrkGEAyC2kh1PrOr1IU+2J0csl5oAmLk0ZpzG/TEaztle+0Yu2yg1IX2DeV0RzkUskY QlMBhEiZjmXtqXcO6XfohaeAJBotya4zr5h0Vb/5iPAvrwZxkwrBv/kr3YVEWe78fx9+ /zeMgaWiN0PCwvLlWfbfU/mO9LLjC7PkNOXniW8ltm/x9TOr1W8eU2J1fNVwcf6pcNhh pmYw== X-Gm-Message-State: AC+VfDxGcM+TRn/dX0prAUk1hzKW89Xuir39/1pCLpJy6aqWYj/ZO16C 21nCFcysMaEXKtCFR2pCEw== X-Google-Smtp-Source: ACHHUZ4BPmwhYeRuCB1b3WD8WeQpdEUY5Y/vga5MesEG9brj/gXSLEqJny1Nwo0NSJlCoeZIxy778g== X-Received: by 2002:a5e:9508:0:b0:785:fbe8:1da0 with SMTP id r8-20020a5e9508000000b00785fbe81da0mr5086305ioj.15.1688052219729; Thu, 29 Jun 2023 08:23:39 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id ei23-20020a05663829b700b0042ad757be01sm2260064jab.121.2023.06.29.08.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 08:23:38 -0700 (PDT) Received: (nullmailer pid 3060526 invoked by uid 1000); Thu, 29 Jun 2023 15:23:35 -0000 Date: Thu, 29 Jun 2023 09:23:35 -0600 From: Rob Herring To: Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Benjamin Li , James Willcox , Joseph Gates , Stephan Gerhold , Zac Crosby , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Lee Jones , Stephen Boyd , Joerg Roedel , Will Deacon , Robin Murphy , Greg Kroah-Hartman , Xu Yang , Peng Fan , Christian Marangi , Wesley Cheng , Jun Nie , Max Chen , Shawn Guo , Vivek Gautam , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Knecht , "Bryan O'Donoghue" , Konrad Dybcio , alsa-devel@alsa-project.org, iommu@lists.linux.dev, linux-usb@vger.kernel.org, Krzysztof Kozlowski , Leo Yan , Andy Gross Subject: Re: [PATCH 08/11] dt-bindings: usb: ci-hdrc-usb2: Fix handling pinctrl properties Message-ID: <20230629152335.GA3055525-robh@kernel.org> References: <20230627-topic-more_bindings-v1-0-6b4b6cd081e5@linaro.org> <20230627-topic-more_bindings-v1-8-6b4b6cd081e5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627-topic-more_bindings-v1-8-6b4b6cd081e5@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 27, 2023 at 06:24:24PM +0200, Konrad Dybcio wrote: > Untangle the bit messy oneOf trees and add the missing pinctrl-2 mention > to handle the different pinctrl combinations. > > Fixes: 4c8375d35f72 ("dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format") > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 ++++++---------------- > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index 782402800d4a..24431a7adf3e 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -199,17 +199,6 @@ properties: > In case of HSIC-mode, "idle" and "active" pin modes are mandatory. > In this case, the "idle" state needs to pull down the data and > strobe pin and the "active" state needs to pull up the strobe pin. > - oneOf: > - - items: > - - const: idle > - - const: active These are no longer valid values? The description still mentions them. > - - items: > - - const: default > - - enum: > - - host > - - device > - - items: > - - const: default > > pinctrl-0: > maxItems: 1 > @@ -357,17 +346,15 @@ allOf: > - const: active > else: > properties: > + pinctrl-2: This should be implicitly allowed. Is it not? I'm reallly at a loss as to what problem this patch solves. > + maxItems: 1 > + > pinctrl-names: > minItems: 1 > - maxItems: 2 > - oneOf: > - - items: > - - const: default > - - enum: > - - host > - - device > - - items: > - - const: default > + items: > + - const: default > + - const: host > + - const: device > - if: > properties: > compatible: > > -- > 2.41.0 >