From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E3EEB64D7 for ; Fri, 30 Jun 2023 07:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232444AbjF3HsD (ORCPT ); Fri, 30 Jun 2023 03:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjF3Hro (ORCPT ); Fri, 30 Jun 2023 03:47:44 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D99C33C19 for ; Fri, 30 Jun 2023 00:46:51 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-51d7f350758so1881291a12.3 for ; Fri, 30 Jun 2023 00:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1688111210; x=1690703210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gkEVUn+BSGCw26Br9R1zJay0XQU2Hj1OrR3nyO4XYMs=; b=pXW7rqo2IPCCQNelaVb4brBvc66A3ZsWjaSvhuweZhbnHl52z8pQnkZvsPvTuVFnjl O8sSSJB0DWG46EaLZsvx1SOe+L/d37a9A0x6Pevillxw2A/kVu0f3BQT78pI7QFeCwZp G2RZH9s5TafP0LSUNkJZ3Ovd/EcLBs6haxbhhkqWvvDTwNZql5nbOBbMc5AJLWw96j01 bO7wHfy0r8BbfI23SDIZN5JRXVO6/sOLrrKypk3TSwwoR7EpX8rRtDLO05FoUywhlI/N xI1lmHzC5sKJ2bN+jiDxyTOWr1cTFW4pxG+g1r0ycbnhuIqVpMPXwBTgLmCn5DF5EVoZ TaZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688111210; x=1690703210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gkEVUn+BSGCw26Br9R1zJay0XQU2Hj1OrR3nyO4XYMs=; b=RtLEBH/oXJu1xkSyKMJNzIVQG5WwxDvr5I7qfa+nM1LbUVlqcrc8mR5ghVaMhOPTMl eAar7WJgrmVpESDfuxWR/P2Tq07wj1QD/+83Ks/ujLiHrXUQbtN7onhd+udTBj2+lrcw UN3jCWHbTK5cBd4YxZhlp01o7ifUVBQkSI69Q/I2HaeeGZXIY70DZop1vVbZ8uTs3eX8 XeIsjX+/s4fKwgsf9Q7Zg6eBs2QPZbEE3T3p8fw7jeSTxZB6JkQTB30ne34jTFZTY+fM v8IHlT+AlyfDAeokJQKbwikJdt4vOU/pe+qEI8p4X/7v6U9FMqeGH2NM2IOD+bZO7s0u YjPg== X-Gm-Message-State: ABy/qLa/burFMPSwvdHqoRk7uz1SDWnggx0COZ1tCT4IsvBJvtha5YFi TewLjiq0omFBICMOhLHXGn5ClA== X-Google-Smtp-Source: APBJJlFgqHa9gDbozF0P92T72GWSMIP3fuYpYu4HFpS6dAtkIvNTi5BLg3397B7OHXeTVHiRxxPH/Q== X-Received: by 2002:aa7:d98f:0:b0:51d:e59c:6190 with SMTP id u15-20020aa7d98f000000b0051de59c6190mr1208294eds.2.1688111209947; Fri, 30 Jun 2023 00:46:49 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id i12-20020aa7dd0c000000b0051830f22825sm6503023edv.90.2023.06.30.00.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 00:46:49 -0700 (PDT) Date: Fri, 30 Jun 2023 09:46:48 +0200 From: Andrew Jones To: Conor Dooley Cc: Palmer Dabbelt , Conor Dooley , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Paul Walmsley , aou@eecs.berkeley.edu, heiko.stuebner@vrull.eu, Evan Green , sunilvl@ventanamicro.com, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/10] RISC-V: provide a Kconfig option to disable parsing "riscv,isa" Message-ID: <20230630-7d0f6fe66c9415315d491f15@orel> References: <20230629-landed-popsicle-ab46ab3b46d9@spud> <20230629-angled-gallantly-8fe7451a25fa@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629-angled-gallantly-8fe7451a25fa@spud> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 29, 2023 at 10:44:18PM +0100, Conor Dooley wrote: > On Thu, Jun 29, 2023 at 02:16:49PM -0700, Palmer Dabbelt wrote: > > On Thu, 29 Jun 2023 13:20:55 PDT (-0700), Conor Dooley wrote: ... > > > +bool __initdata riscv_isa_fallback_cmdline = false; > > > +static int __init riscv_isa_fallback_setup(char *__unused) > > > > Maybe it's better to support =true and =false here? Not sure it matters, > > we're already down a rabbit hole ;) > > Dunno, not implemented a cmdline param before. Seemed "cleaner" to check > for presence, don't really care so I'll adapt to w/e. > I don't have a strong preference here, but to throw in more food for thought, I see this DT-v1 vs. DT-v2 choice to be a bit analogous to the DT vs. ACPI choice. The 'acpi' command line parameter, for RISC-V, can be 'off', 'on', and 'force', where off -- disable ACPI if default was on on -- enable ACPI but allow fallback to DT force -- enable ACPI if default was off So, if the default of the isa fallback command line option will depend on Kconfig, then we may also want a 'force'. Thanks, drew