From: Bjorn Helgaas <helgaas@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org,
bharat.kumar.gogada@amd.com, michals@amd.com
Subject: Re: [PATCH V5 1/3] Move and rename error interrupt bits to a common header.
Date: Fri, 30 Jun 2023 16:49:30 -0500 [thread overview]
Message-ID: <20230630214930.GA496585@bhelgaas> (raw)
In-Reply-To: <20230628092812.1592644-2-thippeswamy.havalige@amd.com>
The subject line needs to contain "PCI: " and the driver name.
The subject line also should not end with a period.
It looks like some of these interrupt bits are not errors.
Mentioned previously at https://lore.kernel.org/r/ZF6SHJ44s4OqPYj4@bhelgaas
Suggest this instead:
PCI: xilinx-cpm: Move interrupt bit definitions to common header
On Wed, Jun 28, 2023 at 02:58:10PM +0530, Thippeswamy Havalige wrote:
> Move and rename error interrupt bit macros to a common header file for
> code reusability.
Suggest this:
Rename Xilinx interrupt bit definitions so they are not
CPM-specific. Move the definitions to pcie-xilinx-common.h where
they can be shared between pcie-xilinx-cpm and the new xilinx-xdma
driver.
> Move common linux header files for reusability.
This sentence is redundant and should be removed.
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
Bjorn
next prev parent reply other threads:[~2023-06-30 21:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 9:28 [PATCH V5 0/3] Add support for Xilinx XDMA Soft IP as Root Port Thippeswamy Havalige
2023-06-28 9:28 ` [PATCH V5 1/3] Move and rename error interrupt bits to a common header Thippeswamy Havalige
2023-06-30 21:49 ` Bjorn Helgaas [this message]
2023-06-28 9:28 ` [PATCH V5 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge Thippeswamy Havalige
2023-06-28 10:18 ` Rob Herring
2023-06-28 15:48 ` Rob Herring
2023-06-28 15:49 ` Rob Herring
2023-06-28 9:28 ` [PATCH V5 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver Thippeswamy Havalige
2023-06-30 23:18 ` Bjorn Helgaas
2023-07-20 6:37 ` Havalige, Thippeswamy
2023-07-20 15:24 ` Bjorn Helgaas
2023-07-24 6:40 ` Havalige, Thippeswamy
2023-07-27 23:27 ` Bjorn Helgaas
2023-07-31 6:17 ` Havalige, Thippeswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630214930.GA496585@bhelgaas \
--to=helgaas@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@amd.com \
--cc=robh+dt@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).