From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90260C0015E for ; Fri, 7 Jul 2023 07:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232655AbjGGHpb (ORCPT ); Fri, 7 Jul 2023 03:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232619AbjGGHpP (ORCPT ); Fri, 7 Jul 2023 03:45:15 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F046826AB for ; Fri, 7 Jul 2023 00:44:58 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-55ba5bb0bf3so1078184a12.1 for ; Fri, 07 Jul 2023 00:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688715898; x=1691307898; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nc8hsYfP7p2/uQcQVsM1gSYitt4Oq+PGcwvXsUY6Xd0=; b=IfQPY7vmxYj1PcxBJ0L3J2rLmRwRg+zUfuHzIsME0fm2M91udhvySx62cP6yywzzt4 KvOhwLh26kqJDnlf4IWE6uxj7II+T9pWexx/jm2CZTWedS1BBLEJ+VGwRDfMJWobxkzU R6+YJfBK93Rs3VXc+oSsLQJWfGGEMgIhMdvo58QveX/EPSvDd/k1YRO1f3p3Fc6t7vwh mrJqYVOH1zbrU1JJY1lCau/2jGzd+C5QrTK9htklBC46EHvzNiHnmjLqmyKv+JJjYf4p j56zOTQY/ZEv19FVy4NWdQaasJ/KK/qNqbFEr1QngwHfGm+fiodQHrhWWd4aOb2naWmT a1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688715898; x=1691307898; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nc8hsYfP7p2/uQcQVsM1gSYitt4Oq+PGcwvXsUY6Xd0=; b=AtwuRnxZ52DKRrmrMU8hjoPRX8/LrmwzxkOZgzxW56gven6ckFR/KVQt0jwi7jtzsl TQju3KXkvBzOKVsE3Rv25fuhNq3eU4UUNEkwr/fk0iS+46DV1VbDH0KFhGru1dKyEYEr Wum/JMg6WLXjqwKcRPW3W5vXXOXhQ3n3sfyBdxu21hfwqQxM5C0dtjbr3d7QcDhWAkAV 1ImCJCPe+pMznr9J/BDAS0hekho9G/czEAdIPYbNiVPvHkBsZVe2weRY9/D8UjMLdfNY 3F99h8NL49hAdrhYra7IfUCbACXSyZSo0E39e5PspzineutuCKLKoZt8Qt9ENAgIW63Z DNUA== X-Gm-Message-State: ABy/qLaeOnDiedabVy1PZljAYO7KNJLPQBJXGuwwSLV+BmDRnzxkMV69 0mw0QqEgO3ySD9ZJE193MVu8 X-Google-Smtp-Source: APBJJlE1giAF5ktcBdYwyPiW/RITGSYsHtaTsJIfAlizZBMQzPCsDxxmt3RXdsUWwYCMtjhL8i2biA== X-Received: by 2002:a05:6a20:8f2a:b0:12f:5f2b:cbb0 with SMTP id b42-20020a056a208f2a00b0012f5f2bcbb0mr10538469pzk.23.1688715898358; Fri, 07 Jul 2023 00:44:58 -0700 (PDT) Received: from thinkpad ([117.216.120.82]) by smtp.gmail.com with ESMTPSA id z6-20020a633306000000b0051b460fd90fsm2382435pgz.8.2023.07.07.00.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 00:44:57 -0700 (PDT) Date: Fri, 7 Jul 2023 13:14:49 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 1/3] clk: qcom: gcc-sc8280xp: Add missing GDSC flags Message-ID: <20230707074449.GJ6001@thinkpad> References: <20230620-topic-sc8280_gccgdsc-v2-0-562c1428c10d@linaro.org> <20230620-topic-sc8280_gccgdsc-v2-1-562c1428c10d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230620-topic-sc8280_gccgdsc-v2-1-562c1428c10d@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jun 26, 2023 at 07:48:06PM +0200, Konrad Dybcio wrote: > All of the 8280's GCC GDSCs can and should use the retain registers so > as not to lose their state when entering lower power modes. > > Fixes: d65d005f9a6c ("clk: qcom: add sc8280xp GCC driver") > Signed-off-by: Konrad Dybcio Acked-by: Manivannan Sadhasivam - Mani > --- > drivers/clk/qcom/gcc-sc8280xp.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b90c71637814..64bea886322d 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -6761,7 +6761,7 @@ static struct gdsc pcie_0_tunnel_gdsc = { > .name = "pcie_0_tunnel_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE, > + .flags = VOTABLE | RETAIN_FF_ENABLE, > }; > > static struct gdsc pcie_1_tunnel_gdsc = { > @@ -6772,7 +6772,7 @@ static struct gdsc pcie_1_tunnel_gdsc = { > .name = "pcie_1_tunnel_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE, > + .flags = VOTABLE | RETAIN_FF_ENABLE, > }; > > /* > @@ -6787,7 +6787,7 @@ static struct gdsc pcie_2a_gdsc = { > .name = "pcie_2a_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE | ALWAYS_ON, > + .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON, > }; > > static struct gdsc pcie_2b_gdsc = { > @@ -6798,7 +6798,7 @@ static struct gdsc pcie_2b_gdsc = { > .name = "pcie_2b_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE | ALWAYS_ON, > + .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON, > }; > > static struct gdsc pcie_3a_gdsc = { > @@ -6809,7 +6809,7 @@ static struct gdsc pcie_3a_gdsc = { > .name = "pcie_3a_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE | ALWAYS_ON, > + .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON, > }; > > static struct gdsc pcie_3b_gdsc = { > @@ -6820,7 +6820,7 @@ static struct gdsc pcie_3b_gdsc = { > .name = "pcie_3b_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE | ALWAYS_ON, > + .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON, > }; > > static struct gdsc pcie_4_gdsc = { > @@ -6831,7 +6831,7 @@ static struct gdsc pcie_4_gdsc = { > .name = "pcie_4_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE | ALWAYS_ON, > + .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON, > }; > > static struct gdsc ufs_card_gdsc = { > @@ -6840,6 +6840,7 @@ static struct gdsc ufs_card_gdsc = { > .name = "ufs_card_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc ufs_phy_gdsc = { > @@ -6848,6 +6849,7 @@ static struct gdsc ufs_phy_gdsc = { > .name = "ufs_phy_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc usb30_mp_gdsc = { > @@ -6856,6 +6858,7 @@ static struct gdsc usb30_mp_gdsc = { > .name = "usb30_mp_gdsc", > }, > .pwrsts = PWRSTS_RET_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc usb30_prim_gdsc = { > @@ -6864,6 +6867,7 @@ static struct gdsc usb30_prim_gdsc = { > .name = "usb30_prim_gdsc", > }, > .pwrsts = PWRSTS_RET_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc usb30_sec_gdsc = { > @@ -6872,6 +6876,7 @@ static struct gdsc usb30_sec_gdsc = { > .name = "usb30_sec_gdsc", > }, > .pwrsts = PWRSTS_RET_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc emac_0_gdsc = { > @@ -6880,6 +6885,7 @@ static struct gdsc emac_0_gdsc = { > .name = "emac_0_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct gdsc emac_1_gdsc = { > @@ -6888,6 +6894,7 @@ static struct gdsc emac_1_gdsc = { > .name = "emac_1_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > + .flags = RETAIN_FF_ENABLE, > }; > > static struct clk_regmap *gcc_sc8280xp_clocks[] = { > > -- > 2.41.0 > -- மணிவண்ணன் சதாசிவம்