From: Andreas Kemnade <andreas@kemnade.info>
To: Mark Brown <broonie@kernel.org>
Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
peter.ujfalusi@gmail.com, jarkko.nikula@bitmer.com,
dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode
Date: Sat, 8 Jul 2023 15:03:19 +0200 [thread overview]
Message-ID: <20230708150319.202789c1@aktux> (raw)
In-Reply-To: <eeba3297-acdb-45ca-a80d-40d8b3a90231@sirena.org.uk>
Hi,
On Thu, 6 Jul 2023 13:02:36 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jul 05, 2023 at 09:56:11PM +0200, Andreas Kemnade wrote:
> > Mark Brown <broonie@kernel.org> wrote:
>
> > > It would be nicer to set the clock via the DT bindings, ideally with the
> > > clock bindings...
>
> > I found no path from these simple-audio-card things to provide a clk_id
> > to set_dai_sysclk. I would of course prefer such a thing. Do I have overlooked
> > something?
>
> Since we already have clock bindings we should use those to configure
> the clocks, there's several drivers that have added this support already
> - look for clock providers.
ok, looking around:
Just to make sure I am not running in a bad direction: Do you think
tlv320aic32x4{,-clk}.c is a good example? It is ignoring clk_id.
I was mentally bound to have to use clk_id there, so I did not found a good
solution.
So I guess I have to configure the chip as a master and using mclk and compare
register dumps with the state we have now and the state after the changes,
additionally to check bclk functionality directly.
Regards,
Andreas
next prev parent reply other threads:[~2023-07-08 13:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:03 [PATCH 0/3] ARM: omap4: embt2ws: Add audio support Andreas Kemnade
2023-07-05 19:03 ` [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Andreas Kemnade
2023-09-19 18:25 ` Péter Ujfalusi
2023-09-20 6:33 ` Tony Lindgren
2023-09-20 14:52 ` Andreas Kemnade
2023-09-20 17:24 ` Péter Ujfalusi
2023-09-20 17:40 ` Péter Ujfalusi
2023-09-21 12:16 ` Tony Lindgren
2023-10-06 10:23 ` Tony Lindgren
2023-10-06 19:30 ` Andreas Kemnade
2023-10-07 6:25 ` Tony Lindgren
2023-10-07 7:11 ` Andreas Kemnade
2023-10-07 7:41 ` Tony Lindgren
2023-10-07 8:34 ` Andreas Kemnade
2023-10-12 14:41 ` Péter Ujfalusi
2023-10-13 11:25 ` Andreas Kemnade
2023-10-25 14:21 ` Péter Ujfalusi
2023-10-15 21:48 ` Andreas Kemnade
2023-10-18 5:23 ` Tony Lindgren
2023-10-18 6:21 ` Andreas Kemnade
2023-07-05 19:03 ` [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode Andreas Kemnade
2023-07-05 19:21 ` Mark Brown
2023-07-05 19:56 ` Andreas Kemnade
2023-07-06 12:02 ` Mark Brown
2023-07-08 13:03 ` Andreas Kemnade [this message]
2023-07-10 16:36 ` Mark Brown
2023-07-05 19:03 ` [PATCH 3/3] ARM: dts: omap4: embt2ws: Add audio support Andreas Kemnade
2023-07-05 19:23 ` Mark Brown
2023-07-19 17:47 ` (subset) [PATCH 0/3] ARM: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708150319.202789c1@aktux \
--to=andreas@kemnade.info \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).