From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D872EB64DA for ; Sat, 8 Jul 2023 16:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbjGHQXq (ORCPT ); Sat, 8 Jul 2023 12:23:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjGHQXp (ORCPT ); Sat, 8 Jul 2023 12:23:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094021B5; Sat, 8 Jul 2023 09:23:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E3B560D3E; Sat, 8 Jul 2023 16:23:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 288F6C433C7; Sat, 8 Jul 2023 16:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688833424; bh=A99StwgY1zVXF+35oUPoJCWd4DIdXY+XY+Fo3IdGtGg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=plJOZS8ECyGooTXfwF7IOYvuuOWM1+09HRUTTotfwfuvmTHIAq8kADJQi4FyKUR1Z +OOdRQLXZmBpLAB4Yvad49q6DDJhg5x6ueoQTqa/teoi8P5qo5yYOKbTJYxVRD2KGH PZ3pM+liDaluVVK0Dd4SlyCli46Zyh9MFX6qU/AQ5wm7nlYe8TYUQ55R6vSn6bq1I8 I4IQCfiUszMuaeZ9OxuOGhGzEmyUWttsQXgeNhIEVv3rZXz44VBalFmRPRtGLWWQNW wonaGj3XLW/CdjgvmshixOSCm9aiahcCNE7Awt18SdrwNXnv6uu2eDHTPWGz4M/Wbz IxfR2cIppiRUw== Date: Sat, 8 Jul 2023 17:23:36 +0100 From: Jonathan Cameron To: Mehdi Djait Cc: mazziesaccount@gmail.com, krzysztof.kozlowski+dt@linaro.org, andriy.shevchenko@linux.intel.com, robh+dt@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 0/7] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer Message-ID: <20230708172336.79e68a0f@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 13 Jun 2023 12:22:33 +0200 Mehdi Djait wrote: > Hello everyone, > > Version 6 for adding support for the kx132-1211 accelerometer > > KX132-1211 accelerometer is a sensor which: > - supports G-ranges of (+/-) 2, 4, 8, and 16G > - can be connected to I2C or SPI > - has internal HW FIFO buffer > - supports various ODRs (output data rates) > > The KX132-1211 accelerometer is very similar to the KX022A. > One key difference is number of bits to report the number of data bytes that > have been stored in the buffer: 8 bits for KX022A vs 10 bits for > KX132-1211. > Just though I'd say that the series looks fine to me. I'm just waiting on reply to Matti's query on the last patch before applying it. Thanks, Jonathan > Changes in v6: > - check for availability of chip_info for the SPI case > - changed the order of elements in the kx022a_data struct to save memory > > Changes in v5: > - moved the "kfree" call to match the reverse of what happens in > kx022a_fifo_enable() as suggested by Matti and Jonathan > - used min_t, checked for availability of chip_info and moved the > position of u16 buf_smp_lvl_mask as suggested by Andy > - introduced buf_smp_lvl_mask in Patch 7 as suggested by Jonathan > > Changes in v4: > - moved the allocation of the fifo_buffer to kx022a_fifo_enable and > kx022a_fifo_disable > - some fixes to the regmap ranges of kx132-1211 > > Changes in v3: > - added two new patches by separating the addition of the > i2c_device_id table and the removal of blank lines from other > unrelated changes > - fixes a warning detected by the kernel test robot > - made all the changes related the chip_info in one patch > > Changes in v2: > - added a new patch for warning when the device_id match fails in the > probe function > - added a new patch for the function that retrieves the number of bytes > in the buffer > - added a change to the Kconfig file in the patch adding the support > for the kx132-1211 > - various fixes and modifications listed under each patch > > Mehdi Djait (7): > dt-bindings: iio: Add KX132-1211 accelerometer > iio: accel: kionix-kx022a: Remove blank lines > iio: accel: kionix-kx022a: Warn on failed matches and assume > compatibility > iio: accel: kionix-kx022a: Add an i2c_device_id table > iio: accel: kionix-kx022a: Refactor driver and add chip_info structure > iio: accel: kionix-kx022a: Add a function to retrieve number of bytes > in buffer > iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer > > .../bindings/iio/accel/kionix,kx022a.yaml | 12 +- > drivers/iio/accel/Kconfig | 8 +- > drivers/iio/accel/kionix-kx022a-i2c.c | 24 +- > drivers/iio/accel/kionix-kx022a-spi.c | 15 +- > drivers/iio/accel/kionix-kx022a.c | 312 ++++++++++++++---- > drivers/iio/accel/kionix-kx022a.h | 110 +++++- > 6 files changed, 406 insertions(+), 75 deletions(-) >