From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Piyush Mehta <piyush.mehta@amd.com>,
nava.kishore.manne@amd.com, linux-kernel@vger.kernel.org,
git@amd.com, wsa@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
dlemoal@kernel.org, michal.simek@amd.com,
sebastian.reichel@collabora.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: add reset-controller property
Date: Mon, 10 Jul 2023 17:41:10 +0100 [thread overview]
Message-ID: <20230710-hatchery-pesky-6f837788e576@spud> (raw)
In-Reply-To: <168892849854.136160.7620779203584875736.robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2498 bytes --]
On Sun, Jul 09, 2023 at 12:48:18PM -0600, Rob Herring wrote:
>
> On Sun, 09 Jul 2023 22:55:42 +0530, Piyush Mehta wrote:
> > The reset controller is responsible for managing both device-level resets
> > and individual PMC (Power Management Controller) block resets.
> >
> > To facilitate this functionality reset-controller property is added to the
> > firmware device tree binding.
> >
> > Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> > ---
> > .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: versal-firmware: reset-controller: False schema does not allow {'compatible': ['xlnx,zynqmp-reset'], '#reset-cells': [[1]]}
> from schema $id: http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml#
> Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: /example-0/versal-firmware/reset-controller: failed to match any schema with compatible: ['xlnx,zynqmp-reset']
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230709172542.1393828-1-piyush.mehta@amd.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
When you fix this error, please add an indication of the platform in
question to $subject, "dt-bindings: firmware: add reset-controller property"
sounds like it applies to all firmware bindings..
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-07-10 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 17:25 [PATCH] dt-bindings: firmware: add reset-controller property Piyush Mehta
2023-07-09 18:48 ` Rob Herring
2023-07-10 16:41 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710-hatchery-pesky-6f837788e576@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nava.kishore.manne@amd.com \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox